[jira] [Commented] (HIVE-26411) Fix TestReplicationMetricCollector flakiness

["Hankó Gergely (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HIVE-26411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17569961#comment-17569961 ] 

Hankó Gergely commented on HIVE-26411:
--------------------------------------

Merged to master, [https://github.com/apache/hive/commit/d4f0ef592c1cded474fe0be7077effa6308dc466]

Thanks [~kkasa].

> Fix TestReplicationMetricCollector flakiness
> --------------------------------------------
>
>                 Key: HIVE-26411
>                 URL: https://issues.apache.org/jira/browse/HIVE-26411
>             Project: Hive
>          Issue Type: Bug
>          Components: Tests
>            Reporter: Hankó Gergely
>            Assignee: Hankó Gergely
>            Priority: Minor
>              Labels: pull-request-available
>          Time Spent: 50m
>  Remaining Estimate: 0h
>
> TestReplicationMetricCollector tests can fail intermittently because 
> ReplicationMetricCollector schedules a MetrikSink thread that consumes the MetricCollector's 
> metricMap regularly and if this happens at the wrong time, the tests, that use the MetricCollector.getInstance().getMetrics() method, can fail.
> Example stack trace:
> {code:java}
> java.lang.AssertionError: expected:<1> but was:<0> at org.junit.Assert.fail(Assert.java:88) at org.junit.Assert.failNotEquals(Assert.java:743) at org.junit.Assert.assertEquals(Assert.java:118) at org.junit.Assert.assertEquals(Assert.java:555) at org.junit.Assert.assertEquals(Assert.java:542) at org.apache.hadoop.hive.ql.parse.repl.metric.TestReplicationMetricCollector.testFailoverReadyDumpMetrics(TestReplicationMetricCollector.java:227){code}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)