You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@james.apache.org by GitBox <gi...@apache.org> on 2021/04/17 10:21:30 UTC
[GitHub] [james-project] chibenwa opened a new pull request #396: JAMES-3261 ZIP packaging for all Guice servers
chibenwa opened a new pull request #396:
URL: https://github.com/apache/james-project/pull/396
**Why**: Allows to put the ZIPs on the download page (From next release! So likely 3.6.1... Once the backport is done...)
**Expected outcome**: More people should be using Guice products as a full compilation is no longer needed. This might be the first step to deprecate and eventually remove Spring packaging.
I had a productive Saturday:
- Created a ZIP packaging that reuses the configuration files of the docker
- Provided instructions to run the binary once unziped
- Rewrote the docker images to rely on the ZIP - waiting for having JIB directly doing the work!
- Manually tested everything...
- Dropped the LDAP specialized docker image as their non-LDAP counter part now allows LDAP to be configured.
Once released and available for uploads, existing install guides needs to be updated to rely on the uploads... (Not for today.)
Enjoy!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org
[GitHub] [james-project] jeantil commented on pull request #396: JAMES-3261 ZIP packaging for all Guice servers
Posted by GitBox <gi...@apache.org>.
jeantil commented on pull request #396:
URL: https://github.com/apache/james-project/pull/396#issuecomment-828604601
> Using symbolic links? If it works with the ZIP then I would be happy.
not really but this was simply a comment don't let it hold you
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org
[GitHub] [james-project] rouazana commented on a change in pull request #396: JAMES-3261 ZIP packaging for all Guice servers
Posted by GitBox <gi...@apache.org>.
rouazana commented on a change in pull request #396:
URL: https://github.com/apache/james-project/pull/396#discussion_r617354470
##########
File path: dockerfiles/run/guice/memory/Dockerfile
##########
@@ -22,7 +22,10 @@ RUN apt-get update && apt-get install -y unzip
# Get data we need to run James : build results and configuration
ADD destination/james-server-memory-guice.zip /root
-RUN unzip james-server-memory-guice.zip && cp -r /root/james-server-memory-guice/* /root
+RUN unzip james-server-memory-guice.zip && \
+ cp -r /root/james-server-memory-guice/* /root && \
+ rm james-server-memory-guice.zip && \
+ rm -r james-server-memory-guice
Review comment:
unzip -d allows to extract to an arbitrary directory
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org
[GitHub] [james-project] rouazana commented on a change in pull request #396: JAMES-3261 ZIP packaging for all Guice servers
Posted by GitBox <gi...@apache.org>.
rouazana commented on a change in pull request #396:
URL: https://github.com/apache/james-project/pull/396#discussion_r617503132
##########
File path: dockerfiles/run/guice/memory/Dockerfile
##########
@@ -22,7 +22,10 @@ RUN apt-get update && apt-get install -y unzip
# Get data we need to run James : build results and configuration
ADD destination/james-server-memory-guice.zip /root
-RUN unzip james-server-memory-guice.zip && cp -r /root/james-server-memory-guice/* /root
+RUN unzip james-server-memory-guice.zip && \
+ cp -r /root/james-server-memory-guice/* /root && \
+ rm james-server-memory-guice.zip && \
+ rm -r james-server-memory-guice
Review comment:
oh right sorry for the noise. It's easily doable with tar but unfortunately not with unzip.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org
[GitHub] [james-project] chibenwa commented on pull request #396: JAMES-3261 ZIP packaging for all Guice servers
Posted by GitBox <gi...@apache.org>.
chibenwa commented on pull request #396:
URL: https://github.com/apache/james-project/pull/396#issuecomment-828947555
I just rebased to solve a trivial conflict.
If there is any additional comments on this, I would be happy to open follow up PRs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org
[GitHub] [james-project] chibenwa merged pull request #396: JAMES-3261 ZIP packaging for all Guice servers
Posted by GitBox <gi...@apache.org>.
chibenwa merged pull request #396:
URL: https://github.com/apache/james-project/pull/396
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org
[GitHub] [james-project] chibenwa commented on pull request #396: JAMES-3261 ZIP packaging for all Guice servers
Posted by GitBox <gi...@apache.org>.
chibenwa commented on pull request #396:
URL: https://github.com/apache/james-project/pull/396#issuecomment-828379910
It's open for weeks. The potentiality of conflicts high.
Committers, should I move forward and merge this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org
[GitHub] [james-project] chibenwa commented on a change in pull request #396: JAMES-3261 ZIP packaging for all Guice servers
Posted by GitBox <gi...@apache.org>.
chibenwa commented on a change in pull request #396:
URL: https://github.com/apache/james-project/pull/396#discussion_r617431986
##########
File path: dockerfiles/run/guice/memory/Dockerfile
##########
@@ -22,7 +22,10 @@ RUN apt-get update && apt-get install -y unzip
# Get data we need to run James : build results and configuration
ADD destination/james-server-memory-guice.zip /root
-RUN unzip james-server-memory-guice.zip && cp -r /root/james-server-memory-guice/* /root
+RUN unzip james-server-memory-guice.zip && \
+ cp -r /root/james-server-memory-guice/* /root && \
+ rm james-server-memory-guice.zip && \
+ rm -r james-server-memory-guice
Review comment:
Yes but it do not change the fact that everything is bundled in a `james-server-memory-guice`
I tried:
```
RUN unzip james-server-memory-guice.zip -d /root && rm james-server-memory-guice.zip
```
It deflates:
```
Step 6/21 : RUN unzip james-server-memory-guice.zip -d /root && rm james-server-memory-guice.zip
---> Running in 4bfb050ef3e1
Archive: james-server-memory-guice.zip
creating: /root/james-server-memory-guice/
creating: /root/james-server-memory-guice/extensions-jars/
creating: /root/james-server-memory-guice/conf/
creating: /root/james-server-memory-guice/james-server-memory-guice.lib/
inflating: /root/james-server-memory-guice/README.adoc
inflating: /root/james-server-memory-guice/conf/jmx.properties
inflating: /root/james-server-memory-guice/conf/listeners.xml
inflating: /root/james-server-memory-guice/conf/logback.xml
```
And I got the error:
```
$ docker run -ti mem
Error: Unable to access jarfile james-server-memory-guice.jar
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org
[GitHub] [james-project] Arsnael commented on pull request #396: JAMES-3261 ZIP packaging for all Guice servers
Posted by GitBox <gi...@apache.org>.
Arsnael commented on pull request #396:
URL: https://github.com/apache/james-project/pull/396#issuecomment-828928940
Needs a rebase
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org
[GitHub] [james-project] chibenwa commented on pull request #396: JAMES-3261 ZIP packaging for all Guice servers
Posted by GitBox <gi...@apache.org>.
chibenwa commented on pull request #396:
URL: https://github.com/apache/james-project/pull/396#issuecomment-822529735
> Would it make sense to centralize the sample configuration in a reference/common directory ?
Using symbolic links? If it works with the ZIP then I would be happy.
How would the rendering look like in github (as we use it to show the sample configuration so far)?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org
[GitHub] [james-project] jeantil commented on a change in pull request #396: JAMES-3261 ZIP packaging for all Guice servers
Posted by GitBox <gi...@apache.org>.
jeantil commented on a change in pull request #396:
URL: https://github.com/apache/james-project/pull/396#discussion_r615818357
##########
File path: server/container/guice/cassandra-rabbitmq-guice/README.adoc
##########
@@ -0,0 +1,46 @@
+= Guice-Distributed Server How-to
+
+== Requirements
+
+ * Java 11 SDK
+
+Third party compulsory dependencies:
+
+ * Cassandra 3.11.10
+ * ElasticSearch 7.10.2
+ * RabbitMQ-Management 3.8.1
+ * Zenko Cloudserver or AWS S3
+
+[source]
+----
+$ docker run -d -p 9042:9042 --name=cassandra cassandra:3.11.10
+$ docker run -d -p 9200:9200 --name=elasticsearch --env 'discovery.type=single-node' docker.elastic.co/elasticsearch/elasticsearch:7.10.2
+$ docker run -d -p 5672:5672 -p 15672:15672 --name=rabbitmq rabbitmq:3.8.1-management
+$ docker run -d --env 'REMOTE_MANAGEMENT_DISABLE=1' --env 'SCALITY_ACCESS_KEY_ID=accessKey1' --env 'SCALITY_SECRET_ACCESS_KEY=secretKey1' --name=s3 zenko/cloudserver:8.2.6
+----
+
+== Running
+
+To run james, you have to create a directory containing required configuration files.
+
+James requires the configuration to be in a subfolder of working directory that is called
+**conf**. A sample directory is provided with some default values you may need to replace,
Review comment:
A link to THE sample directory would be nice because there are sample configurations all over the project and it's not obvious which one should be used ( not obvious to me at least )
Note that this can be done as a follow-up
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org