[jira] Commented: (OFBIZ-3478) Compares the specified object with this cart item is not in the right way.

["Scott Gray (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/OFBIZ-3478?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12834057#action_12834057 ] 

Scott Gray commented on OFBIZ-3478:
-----------------------------------

Your patch is also not the right way to compare BigDecimals, it should be:
{code}
if (bigDecimal1.compareTo(bigDecimal2) != 0) {
{code}

> Compares the specified object with this cart item is not in the right way.
> --------------------------------------------------------------------------
>
>                 Key: OFBIZ-3478
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3478
>             Project: OFBiz
>          Issue Type: Bug
>          Components: order
>    Affects Versions: SVN trunk
>            Reporter: Amit Sharma
>             Fix For: SVN trunk
>
>         Attachments: OFBIZ-3478.patch
>
>
> In ShoppingCartItem.java compares of the specified object with this cart item is not in the right way.
> It should be
> if (!this.reservLength.equals(reservLength)) {
>    return false;
> }
> instead of 
> if (this.reservLength != reservLength) {
>    return false;
> }

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.