You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by "robertwb (via GitHub)" <gi...@apache.org> on 2024/11/14 00:24:25 UTC
[PR] More complete error message for StripErrorMetadata. [beam]
robertwb opened a new pull request, #33110:
URL: https://github.com/apache/beam/pull/33110
------------------------
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
- [ ] Mention the appropriate issue in your description (for example: `addresses #123`), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment `fixes #<ISSUE NUMBER>` instead.
- [ ] Update `CHANGES.md` with noteworthy changes.
- [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://github.com/apache/beam/blob/master/CONTRIBUTING.md#make-the-reviewers-job-easier).
To check the build health, please visit [https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md](https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md)
GitHub Actions Tests Status (on master branch)
------------------------------------------------------------------------------------------------
[](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Go+tests%22+branch%3Amaster+event%3Aschedule)
See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more information about GitHub Actions CI or the [workflows README](https://github.com/apache/beam/blob/master/.github/workflows/README.md) to see a list of phrases to trigger workflows.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] More complete error message for StripErrorMetadata. [beam]
Posted by "robertwb (via GitHub)" <gi...@apache.org>.
robertwb merged PR #33110:
URL: https://github.com/apache/beam/pull/33110
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] More complete error message for StripErrorMetadata. [beam]
Posted by "damccorm (via GitHub)" <gi...@apache.org>.
damccorm commented on code in PR #33110:
URL: https://github.com/apache/beam/pull/33110#discussion_r1841449585
##########
sdks/python/apache_beam/yaml/yaml_mapping.py:
##########
@@ -467,7 +467,9 @@ def expand(self, pcoll):
break
else:
raise ValueError(
- f"No field name matches one of {self._ERROR_FIELD_NAMES}")
+ 'The input to this transform does not appear to be an error '
+ "output. Expected a schema'd input with a field named "
Review Comment:
```suggestion
+ "output. Expected a schema'd input with a field named "
```
##########
sdks/python/apache_beam/yaml/yaml_mapping.py:
##########
@@ -467,7 +467,9 @@ def expand(self, pcoll):
break
else:
raise ValueError(
- f"No field name matches one of {self._ERROR_FIELD_NAMES}")
+ 'The input to this transform does not appear to be an error '
+ "output. Expected a schema'd input with a field named "
Review Comment:
I think this is breaking checks (may need a formatter run after as well)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] More complete error message for StripErrorMetadata. [beam]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #33110:
URL: https://github.com/apache/beam/pull/33110#issuecomment-2475166243
Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment `assign set of reviewers`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] More complete error message for StripErrorMetadata. [beam]
Posted by "damccorm (via GitHub)" <gi...@apache.org>.
damccorm commented on code in PR #33110:
URL: https://github.com/apache/beam/pull/33110#discussion_r1841495469
##########
sdks/python/apache_beam/yaml/yaml_mapping.py:
##########
@@ -467,7 +467,9 @@ def expand(self, pcoll):
break
else:
raise ValueError(
- f"No field name matches one of {self._ERROR_FIELD_NAMES}")
+ 'The input to this transform does not appear to be an error '
+ + "output. Expected a schema'd input with a field named "
+ + ' or '.join(repr(fld) for fld in self._ERROR_FIELD_NAMES)
Review Comment:
```suggestion
+ ' or '.join(repr(fld) for fld in self._ERROR_FIELD_NAMES))
```
Probably this will still need formatting
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org