You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@commons.apache.org by se...@apache.org on 2009/02/25 01:01:58 UTC

svn commit: r747617 - in /commons/proper/dbcp/trunk/src: java/org/apache/commons/dbcp/datasources/ test/org/apache/commons/dbcp/

Author: sebb
Date: Wed Feb 25 00:01:58 2009
New Revision: 747617

URL: http://svn.apache.org/viewvc?rev=747617&view=rev
Log:
Javadoc corrections

Modified:
    commons/proper/dbcp/trunk/src/java/org/apache/commons/dbcp/datasources/CPDSConnectionFactory.java
    commons/proper/dbcp/trunk/src/java/org/apache/commons/dbcp/datasources/KeyedCPDSConnectionFactory.java
    commons/proper/dbcp/trunk/src/test/org/apache/commons/dbcp/TestConnectionPool.java
    commons/proper/dbcp/trunk/src/test/org/apache/commons/dbcp/TestManual.java

Modified: commons/proper/dbcp/trunk/src/java/org/apache/commons/dbcp/datasources/CPDSConnectionFactory.java
URL: http://svn.apache.org/viewvc/commons/proper/dbcp/trunk/src/java/org/apache/commons/dbcp/datasources/CPDSConnectionFactory.java?rev=747617&r1=747616&r2=747617&view=diff
==============================================================================
--- commons/proper/dbcp/trunk/src/java/org/apache/commons/dbcp/datasources/CPDSConnectionFactory.java (original)
+++ commons/proper/dbcp/trunk/src/java/org/apache/commons/dbcp/datasources/CPDSConnectionFactory.java Wed Feb 25 00:01:58 2009
@@ -110,10 +110,10 @@
 
 
     /**
-     * Sets the {*link ConnectionFactory} from which to obtain base
-     * {*link Connection}s.
-     * @param connFactory the {*link ConnectionFactory} from which to obtain
-     *        base {*link Connection}s
+     * Sets the {@link ConnectionPoolDataSource} from which to obtain base
+     * {@link Connection}s.
+     * @param cpds the {@link ConnectionPoolDataSource} from which to obtain
+     *        base {@link Connection}s
      */
     public synchronized void setCPDS(ConnectionPoolDataSource cpds) {
         _cpds = cpds;

Modified: commons/proper/dbcp/trunk/src/java/org/apache/commons/dbcp/datasources/KeyedCPDSConnectionFactory.java
URL: http://svn.apache.org/viewvc/commons/proper/dbcp/trunk/src/java/org/apache/commons/dbcp/datasources/KeyedCPDSConnectionFactory.java?rev=747617&r1=747616&r2=747617&view=diff
==============================================================================
--- commons/proper/dbcp/trunk/src/java/org/apache/commons/dbcp/datasources/KeyedCPDSConnectionFactory.java (original)
+++ commons/proper/dbcp/trunk/src/java/org/apache/commons/dbcp/datasources/KeyedCPDSConnectionFactory.java Wed Feb 25 00:01:58 2009
@@ -92,7 +92,7 @@
      * Create a new <tt>KeyedPoolableConnectionFactory</tt>.
      * @param cpds the ConnectionPoolDataSource from which to obtain
      * PooledConnections
-     * @param pool the {@link ObjectPool} in which to pool those
+     * @param pool the {@link KeyedObjectPool} in which to pool those
      * {@link Connection}s
      * @param validationQuery a query to use to {@link #validateObject validate}
      * {@link Connection}s.  Should return at least one row. May be <tt>null</tt>
@@ -108,8 +108,8 @@
     }
 
     /**
-     * Sets the {@link ConnectionFactory} from which to obtain base {@link Connection}s.
-     * @param connFactory the {*link ConnectionFactory} from which to obtain base {@link Connection}s
+     * Sets the {@link ConnectionPoolDataSource} from which to obtain base {@link Connection}s.
+     * @param cpds the {@link ConnectionPoolDataSource} from which to obtain base {@link Connection}s
      */
     synchronized public void setCPDS(ConnectionPoolDataSource cpds) {
         _cpds = cpds;

Modified: commons/proper/dbcp/trunk/src/test/org/apache/commons/dbcp/TestConnectionPool.java
URL: http://svn.apache.org/viewvc/commons/proper/dbcp/trunk/src/test/org/apache/commons/dbcp/TestConnectionPool.java?rev=747617&r1=747616&r2=747617&view=diff
==============================================================================
--- commons/proper/dbcp/trunk/src/test/org/apache/commons/dbcp/TestConnectionPool.java (original)
+++ commons/proper/dbcp/trunk/src/test/org/apache/commons/dbcp/TestConnectionPool.java Wed Feb 25 00:01:58 2009
@@ -447,7 +447,7 @@
         conn3.close();
     }
     
-    /** @see http://issues.apache.org/bugzilla/show_bug.cgi?id=12400 */
+    /** @see "http://issues.apache.org/bugzilla/show_bug.cgi?id=12400" */
     public void testConnectionsAreDistinct() throws Exception {
         Connection[] conn = new Connection[getMaxActive()];
         for(int i=0;i<conn.length;i++) {

Modified: commons/proper/dbcp/trunk/src/test/org/apache/commons/dbcp/TestManual.java
URL: http://svn.apache.org/viewvc/commons/proper/dbcp/trunk/src/test/org/apache/commons/dbcp/TestManual.java?rev=747617&r1=747616&r2=747617&view=diff
==============================================================================
--- commons/proper/dbcp/trunk/src/test/org/apache/commons/dbcp/TestManual.java (original)
+++ commons/proper/dbcp/trunk/src/test/org/apache/commons/dbcp/TestManual.java Wed Feb 25 00:01:58 2009
@@ -87,7 +87,7 @@
     }
 
 
-    /** @see http://issues.apache.org/bugzilla/show_bug.cgi?id=28912 */
+    /** @see "http://issues.apache.org/bugzilla/show_bug.cgi?id=28912" */
     public void testReportedBug28912() throws Exception {
         Connection conn1 = getConnection();
         assertNotNull(conn1);
@@ -107,7 +107,7 @@
         assertFalse(conn2.isClosed());
     }
     
-    /** @see http://issues.apache.org/bugzilla/show_bug.cgi?id=12400 */
+    /** @see "http://issues.apache.org/bugzilla/show_bug.cgi?id=12400" */
     public void testReportedBug12400() throws Exception {
         ObjectPool connectionPool = new GenericObjectPool(
             null,