[jira] [Commented] (TS-4427) traffic_logstats: Count TCP_MEM_HIT as a "normal" hit

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/TS-4427?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15275797#comment-15275797 ] 

ASF GitHub Bot commented on TS-4427:
------------------------------------

GitHub user bryancall opened a pull request:

    https://github.com/apache/trafficserver/pull/621

    TS-4427: traffic_logstats: Count TCP_MEM_HIT as a "normal" hit

    

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/bryancall/trafficserver ts-4427

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/trafficserver/pull/621.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #621
    
----
commit 98c7611bbee0642941cabf3f50d27f9546183adb
Author: Bryan Call <bc...@apache.org>
Date:   2016-05-08T23:51:44Z

    TS-4427: traffic_logstats: Count TCP_MEM_HIT as a "normal" hit

----


> traffic_logstats: Count TCP_MEM_HIT as a "normal" hit
> -----------------------------------------------------
>
>                 Key: TS-4427
>                 URL: https://issues.apache.org/jira/browse/TS-4427
>             Project: Traffic Server
>          Issue Type: Bug
>          Components: Tools
>            Reporter: Leif Hedstrom
>            Assignee: Leif Hedstrom
>             Fix For: 7.0.0
>
>
> As of some versions  ago, we start producing Squid log entries with TCP_MEM_HIT properly. This causes a somewhat unusual side effect of having hit metrics in traffic_logstats show up as "hit.others".  Two options:
> 1) Create a new hit/miss metric for "RAM cache" (have to do both without major refactoring of all the code and stuff, since everything is based on symmetry).
> 2) Just bake TCP_MEM_HIT into TCP_HIT.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)