You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Todd Lipcon (Code Review)" <ge...@cloudera.org> on 2020/04/24 23:59:08 UTC
[kudu-CR] Move rowwise serialization to a new .cc file
Todd Lipcon has uploaded this change for review. ( http://gerrit.cloudera.org:8080/15804
Change subject: Move rowwise serialization to a new .cc file
......................................................................
Move rowwise serialization to a new .cc file
Change-Id: Ib6240d38fb6bdee80f5b9041b5ccae3c0257cc09
---
M src/kudu/client/scanner-internal.cc
M src/kudu/common/CMakeLists.txt
A src/kudu/common/row_serialization.cc
A src/kudu/common/row_serialization.h
A src/kudu/common/wire_protocol-test-util.cc
M src/kudu/common/wire_protocol-test-util.h
M src/kudu/common/wire_protocol-test.cc
M src/kudu/common/wire_protocol.cc
M src/kudu/common/wire_protocol.h
M src/kudu/integration-tests/full_stack-insert-scan-test.cc
M src/kudu/tserver/CMakeLists.txt
M src/kudu/tserver/tablet_service.cc
12 files changed, 480 insertions(+), 354 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/04/15804/1
--
To view, visit http://gerrit.cloudera.org:8080/15804
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib6240d38fb6bdee80f5b9041b5ccae3c0257cc09
Gerrit-Change-Number: 15804
Gerrit-PatchSet: 1
Gerrit-Owner: Todd Lipcon <to...@apache.org>
[kudu-CR] Move rowwise serialization to a new .cc file
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15804 )
Change subject: Move rowwise serialization to a new .cc file
......................................................................
Patch Set 1: Code-Review+1
(3 comments)
http://gerrit.cloudera.org:8080/#/c/15804/1//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/15804/1//COMMIT_MSG@7
PS1, Line 7: Move rowwise serialization to a new .cc file
nit: somewhat obvious, but mind noting that this has no major functional changes?
http://gerrit.cloudera.org:8080/#/c/15804/1/src/kudu/common/CMakeLists.txt
File src/kudu/common/CMakeLists.txt:
http://gerrit.cloudera.org:8080/#/c/15804/1/src/kudu/common/CMakeLists.txt@58
PS1, Line 58: row_serialization.cc
nit: flip with row_operations.cc
http://gerrit.cloudera.org:8080/#/c/15804/1/src/kudu/common/wire_protocol-test-util.h
File src/kudu/common/wire_protocol-test-util.h:
http://gerrit.cloudera.org:8080/#/c/15804/1/src/kudu/common/wire_protocol-test-util.h@102
PS1, Line 102:
:
:
nit: drop extras?
--
To view, visit http://gerrit.cloudera.org:8080/15804
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib6240d38fb6bdee80f5b9041b5ccae3c0257cc09
Gerrit-Change-Number: 15804
Gerrit-PatchSet: 1
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Comment-Date: Fri, 01 May 2020 06:00:39 +0000
Gerrit-HasComments: Yes