You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "jiangyinzuo (via GitHub)" <gi...@apache.org> on 2023/03/25 15:52:03 UTC
[GitHub] [arrow-datafusion] jiangyinzuo opened a new pull request, #5741: Modify tests for TPCH explain plans to avoid regressions
jiangyinzuo opened a new pull request, #5741:
URL: https://github.com/apache/arrow-datafusion/pull/5741
# Which issue does this PR close?
<!--
We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes #123` indicates that this PR will close issue #123.
-->
Closes #1377.
# Rationale for this change
<!--
Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes.
-->
I modify `async fn expected_plan()` to utilize `EXPLAIN ...` SQL statement to generate both logical and physical plans and there are only logical plans in `benchmarks/expected-plans/*.txt` before this commit.
# What changes are included in this PR?
<!--
There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR.
-->
test output files in `benchmarks/expected-plans/*.txt` and `async fn expected_plan()` in `tpch.rs`
# Are these changes tested?
<!--
We typically require tests for all PRs in order to:
1. Prevent the code from being accidentally broken by subsequent changes
2. Serve as another way to document the expected behavior of the code
If tests are not included in your PR, please explain why (for example, are they covered by existing tests)?
-->
yes
# Are there any user-facing changes?
<!--
If there are user-facing changes then we may require documentation to be updated before approving the PR.
-->
<!--
If there are any breaking changes to public APIs, please add the `api change` label.
-->
no
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] jiangyinzuo commented on a diff in pull request #5741: Modify tests for TPCH explain plans to avoid regressions
Posted by "jiangyinzuo (via GitHub)" <gi...@apache.org>.
jiangyinzuo commented on code in PR #5741:
URL: https://github.com/apache/arrow-datafusion/pull/5741#discussion_r1148394736
##########
benchmarks/src/bin/tpch.rs:
##########
@@ -525,13 +525,19 @@ mod tests {
let mut actual = String::new();
let sql = get_query_sql(query)?;
for sql in &sql {
- let df = ctx.sql(sql.as_str()).await?;
- let plan = df.into_optimized_plan()?;
- if !actual.is_empty() {
- actual += "\n";
+ if sql.starts_with("select") {
Review Comment:
handle special query 15 which contains `create view` sql statement
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] jiangyinzuo commented on a diff in pull request #5741: Modify tests for TPCH explain plans to avoid regressions
Posted by "jiangyinzuo (via GitHub)" <gi...@apache.org>.
jiangyinzuo commented on code in PR #5741:
URL: https://github.com/apache/arrow-datafusion/pull/5741#discussion_r1148469249
##########
benchmarks/src/bin/tpch.rs:
##########
@@ -562,7 +568,10 @@ mod tests {
}
fn create_context() -> Result<SessionContext> {
Review Comment:
I fix the parameter `target_partitions` so that the generated plans are the same in different machines.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb commented on pull request #5741: Modify tests for TPCH explain plans to avoid regressions
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on PR #5741:
URL: https://github.com/apache/arrow-datafusion/pull/5741#issuecomment-1483856133
Thank you @jiangyinzuo
@andygrove can you give this a look?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] Dandandan commented on pull request #5741: Modify tests for TPCH explain plans to avoid regressions
Posted by "Dandandan (via GitHub)" <gi...@apache.org>.
Dandandan commented on PR #5741:
URL: https://github.com/apache/arrow-datafusion/pull/5741#issuecomment-1484604566
Thank you @jiangyinzuo
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] Dandandan merged pull request #5741: Modify tests for TPCH explain plans to avoid regressions
Posted by "Dandandan (via GitHub)" <gi...@apache.org>.
Dandandan merged PR #5741:
URL: https://github.com/apache/arrow-datafusion/pull/5741
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org