[GitHub] [incubator-superset] graceguo-supercat edited a comment on issue #8553: [dashboard scoped filter] Improve scroll inside modal

[GitBox <gi...@apache.org>]

graceguo-supercat edited a comment on issue #8553: [dashboard scoped filter] Improve scroll inside modal
URL: https://github.com/apache/incubator-superset/pull/8553#issuecomment-553755288
 
 
   > @graceguo-supercat This looks like a good improvement to me! I'm wondering about a couple enhancements, which I can look at in a follow-up PR if you'd like:
   > 
   > • Would it be even better if just the individual tree were to scroll? In this case, that would be just the right side's tree. Optionally, it could even leave the Expand/Collapse/Search pinned to the top.
   > 
   
   Yes! I talked to @kenchendesign and he told me that this is standard interaction behavior for modals actually sidebar and content should scroll separately. 
   
   I added this changed!
   
   For standardize css variables, I would like to do it when we have style guide. currently we prefer to use x`8px` unit for padding/margin spacing.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org