You are viewing a plain text version of this content. The canonical link for it is here.
Posted to cactus-dev@jakarta.apache.org by Vincent Massol <vm...@octo.com> on 2002/08/01 11:56:40 UTC
[VOTE] Rename clientSetUp() and clientTearDown() in 1.5dev
Hi,
Charles Massey has proposed on the 15th of July another name for the
clientSetUp() and clientTearDown() methods : begin() and end().
I think it is a better name than what we have and I propose to make the
change to begin() and end(). It is more logical as we already have
beginXXX() and endXXX() methods.
What do you think ?
Here is my +1
Thanks
-Vincent
--
To unsubscribe, e-mail: <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>
RE: [VOTE] Rename clientSetUp() and clientTearDown() in 1.5dev
Posted by Vincent Massol <vm...@octo.com>.
Hi Patrick,
> -----Original Message-----
> From: Patrick Lightbody [mailto:plightbo@hotmail.com]
> Sent: 02 August 2002 23:52
> To: Vincent Massol; 'Cactus Users List'
> Subject: Re: [VOTE] Rename clientSetUp() and clientTearDown() in
1.5dev
>
> I think I'd survice with begin/end :)
cool. As we have all agreed/accepted the new name, I'll make the change
this week end. Thanks.
>
> Would it be called via reflection still?
I don't understand what's the issue. I explained in a previous email the
additional "features" that reflection was giving us, mostly :
- check for signature and warning if not correct (as opposed to not
issuing any warning and not calling the method)
- ability not to depend on HttpUnit (for the end() method) at compile
*and* runtime!
In addition, in term of implementation, I simply reuse the code that we
already have for calling the beginXXX() and endXXX().
The biggest issue is tying us with HttpUnit at runtime, which I
absolutely don't want (cactus users must be able to write endXXX()
methods without needing HttpClient). So end() method must be called
using reflection.
For begin() we could do without but then it gives us the nice signature
checks, which I like.
What issue do you see with reflection ?
Thanks
-Vincent
>
> ----- Original Message -----
> From: "Vincent Massol" <vm...@octo.com>
> To: "'Patrick Lightbody'" <pl...@hotmail.com>; "'Cactus Users
List'"
> <ca...@jakarta.apache.org>
> Sent: Thursday, August 01, 2002 10:55 AM
> Subject: RE: [VOTE] Rename clientSetUp() and clientTearDown() in
1.5dev
>
>
> >
> >
> > > -----Original Message-----
> > > From: Patrick Lightbody [mailto:plightbo@hotmail.com]
> > > Sent: 01 August 2002 18:48
> > > To: Vincent Massol; 'Cactus Users List'
> > > Subject: Re: [VOTE] Rename clientSetUp() and clientTearDown() in
> > 1.5dev
> > >
> > > Well, since you put it that way... I see your point. My only
concern
> > is
> > > confusion between beginXxx() and begin(), being that one is tied
to an
> > > individual test and the other is tied to the test suite, yet they
both
> > > share
> > > a common name.
> >
> > yes, I also see your point ... :-). I don't really care but we need
a
> > name with which cactus users will be comfortable with as it will be
hard
> > to change once it is released. Hence the vote I have asked. ATM
more
> > persons seem to prefer begin() and end(). Let's let it open for a
few
> > days and we'll see then.
> >
> > Could you live with begin() and end() if that choice was made or are
you
> > categorically -1 ?
> >
> > Thanks
> > -Vincent
> >
> > >
> > > -Pat
> > >
> > > ----- Original Message -----
> > > From: "Vincent Massol" <vm...@octo.com>
> > > To: "'Cactus Users List'" <ca...@jakarta.apache.org>
> > > Cc: "'Patrick Lightbody'" <pl...@hotmail.com>
> > > Sent: Thursday, August 01, 2002 6:43 PM
> > > Subject: RE: [VOTE] Rename clientSetUp() and clientTearDown() in
> > 1.5dev
> > >
> > >
> > > >
> > > >
> > > > > -----Original Message-----
> > > > > From: Patrick Lightbody [mailto:plightbo@hotmail.com]
> > > > > Sent: 01 August 2002 11:11
> > > > > To: Cactus Users List
> > > > > Subject: Re: [VOTE] Rename clientSetUp() and clientTearDown()
in
> > > > 1.5dev
> > > > >
> > > > > Personally I think clientSetUp and clientTearDown make more
sense,
> > > > > assuming
> > > > > they work just like setUp and tearDown (once per test).
> > > >
> > > > ... yes, but Cactus has already extended JUnit by having
beginXXX()
> > and
> > > > endXXX() methods that are executed on the client side. In other
> > words,
> > > > Cactus is "Junit-compliant" on the server side but the client
side
> > is
> > > > purely Cactus-specific.
> > > >
> > > > As we already have beginXXX() and endXXX(), don't you think it
looks
> > > > logical to have begin() and end() being global extensions
(before
> > and
> > > > after each test) ?
> > > >
> > > > Thanks
> > > > -Vincent
> > > >
> > > > >
> > > > > -Pat
> > > > >
> > > > > ----- Original Message -----
> > > > > From: "Vincent Massol" <vm...@octo.com>
> > > > > To: <ca...@jakarta.apache.org>
> > > > > Cc: "'Cactus Users List'" <ca...@jakarta.apache.org>
> > > > > Sent: Thursday, August 01, 2002 10:56 AM
> > > > > Subject: [VOTE] Rename clientSetUp() and clientTearDown() in
> > 1.5dev
> > > > >
> > > > >
> > > > > > Hi,
> > > > > >
> > > > > > Charles Massey has proposed on the 15th of July another name
for
> > the
> > > > > > clientSetUp() and clientTearDown() methods : begin() and
end().
> > > > > >
> > > > > > I think it is a better name than what we have and I propose
to
> > make
> > > > the
> > > > > > change to begin() and end(). It is more logical as we
already
> > have
> > > > > > beginXXX() and endXXX() methods.
> > > > > >
> > > > > > What do you think ?
> > > > > >
> > > > > > Here is my +1
> > > > > >
> > > > > > Thanks
> > > > > > -Vincent
> > > > > >
> > > > > >
> > > > > > --
> > > > > > To unsubscribe, e-mail:
> > > > > <ma...@jakarta.apache.org>
> > > > > > For additional commands, e-mail:
> > > > > <ma...@jakarta.apache.org>
> > > > > >
> > > > >
> > > > > --
> > > > > To unsubscribe, e-mail: <mailto:cactus-user-
> > > > > unsubscribe@jakarta.apache.org>
> > > > > For additional commands, e-mail: <mailto:cactus-user-
> > > > > help@jakarta.apache.org>
> > > >
> >
--
To unsubscribe, e-mail: <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>
Re: [VOTE] Rename clientSetUp() and clientTearDown() in 1.5dev
Posted by Patrick Lightbody <pl...@hotmail.com>.
I think I'd survice with begin/end :)
Would it be called via reflection still?
----- Original Message -----
From: "Vincent Massol" <vm...@octo.com>
To: "'Patrick Lightbody'" <pl...@hotmail.com>; "'Cactus Users List'"
<ca...@jakarta.apache.org>
Sent: Thursday, August 01, 2002 10:55 AM
Subject: RE: [VOTE] Rename clientSetUp() and clientTearDown() in 1.5dev
>
>
> > -----Original Message-----
> > From: Patrick Lightbody [mailto:plightbo@hotmail.com]
> > Sent: 01 August 2002 18:48
> > To: Vincent Massol; 'Cactus Users List'
> > Subject: Re: [VOTE] Rename clientSetUp() and clientTearDown() in
> 1.5dev
> >
> > Well, since you put it that way... I see your point. My only concern
> is
> > confusion between beginXxx() and begin(), being that one is tied to an
> > individual test and the other is tied to the test suite, yet they both
> > share
> > a common name.
>
> yes, I also see your point ... :-). I don't really care but we need a
> name with which cactus users will be comfortable with as it will be hard
> to change once it is released. Hence the vote I have asked. ATM more
> persons seem to prefer begin() and end(). Let's let it open for a few
> days and we'll see then.
>
> Could you live with begin() and end() if that choice was made or are you
> categorically -1 ?
>
> Thanks
> -Vincent
>
> >
> > -Pat
> >
> > ----- Original Message -----
> > From: "Vincent Massol" <vm...@octo.com>
> > To: "'Cactus Users List'" <ca...@jakarta.apache.org>
> > Cc: "'Patrick Lightbody'" <pl...@hotmail.com>
> > Sent: Thursday, August 01, 2002 6:43 PM
> > Subject: RE: [VOTE] Rename clientSetUp() and clientTearDown() in
> 1.5dev
> >
> >
> > >
> > >
> > > > -----Original Message-----
> > > > From: Patrick Lightbody [mailto:plightbo@hotmail.com]
> > > > Sent: 01 August 2002 11:11
> > > > To: Cactus Users List
> > > > Subject: Re: [VOTE] Rename clientSetUp() and clientTearDown() in
> > > 1.5dev
> > > >
> > > > Personally I think clientSetUp and clientTearDown make more sense,
> > > > assuming
> > > > they work just like setUp and tearDown (once per test).
> > >
> > > ... yes, but Cactus has already extended JUnit by having beginXXX()
> and
> > > endXXX() methods that are executed on the client side. In other
> words,
> > > Cactus is "Junit-compliant" on the server side but the client side
> is
> > > purely Cactus-specific.
> > >
> > > As we already have beginXXX() and endXXX(), don't you think it looks
> > > logical to have begin() and end() being global extensions (before
> and
> > > after each test) ?
> > >
> > > Thanks
> > > -Vincent
> > >
> > > >
> > > > -Pat
> > > >
> > > > ----- Original Message -----
> > > > From: "Vincent Massol" <vm...@octo.com>
> > > > To: <ca...@jakarta.apache.org>
> > > > Cc: "'Cactus Users List'" <ca...@jakarta.apache.org>
> > > > Sent: Thursday, August 01, 2002 10:56 AM
> > > > Subject: [VOTE] Rename clientSetUp() and clientTearDown() in
> 1.5dev
> > > >
> > > >
> > > > > Hi,
> > > > >
> > > > > Charles Massey has proposed on the 15th of July another name for
> the
> > > > > clientSetUp() and clientTearDown() methods : begin() and end().
> > > > >
> > > > > I think it is a better name than what we have and I propose to
> make
> > > the
> > > > > change to begin() and end(). It is more logical as we already
> have
> > > > > beginXXX() and endXXX() methods.
> > > > >
> > > > > What do you think ?
> > > > >
> > > > > Here is my +1
> > > > >
> > > > > Thanks
> > > > > -Vincent
> > > > >
> > > > >
> > > > > --
> > > > > To unsubscribe, e-mail:
> > > > <ma...@jakarta.apache.org>
> > > > > For additional commands, e-mail:
> > > > <ma...@jakarta.apache.org>
> > > > >
> > > >
> > > > --
> > > > To unsubscribe, e-mail: <mailto:cactus-user-
> > > > unsubscribe@jakarta.apache.org>
> > > > For additional commands, e-mail: <mailto:cactus-user-
> > > > help@jakarta.apache.org>
> > >
>
--
To unsubscribe, e-mail: <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>
RE: [VOTE] Rename clientSetUp() and clientTearDown() in 1.5dev
Posted by Vincent Massol <vm...@octo.com>.
> -----Original Message-----
> From: Patrick Lightbody [mailto:plightbo@hotmail.com]
> Sent: 01 August 2002 18:48
> To: Vincent Massol; 'Cactus Users List'
> Subject: Re: [VOTE] Rename clientSetUp() and clientTearDown() in
1.5dev
>
> Well, since you put it that way... I see your point. My only concern
is
> confusion between beginXxx() and begin(), being that one is tied to an
> individual test and the other is tied to the test suite, yet they both
> share
> a common name.
yes, I also see your point ... :-). I don't really care but we need a
name with which cactus users will be comfortable with as it will be hard
to change once it is released. Hence the vote I have asked. ATM more
persons seem to prefer begin() and end(). Let's let it open for a few
days and we'll see then.
Could you live with begin() and end() if that choice was made or are you
categorically -1 ?
Thanks
-Vincent
>
> -Pat
>
> ----- Original Message -----
> From: "Vincent Massol" <vm...@octo.com>
> To: "'Cactus Users List'" <ca...@jakarta.apache.org>
> Cc: "'Patrick Lightbody'" <pl...@hotmail.com>
> Sent: Thursday, August 01, 2002 6:43 PM
> Subject: RE: [VOTE] Rename clientSetUp() and clientTearDown() in
1.5dev
>
>
> >
> >
> > > -----Original Message-----
> > > From: Patrick Lightbody [mailto:plightbo@hotmail.com]
> > > Sent: 01 August 2002 11:11
> > > To: Cactus Users List
> > > Subject: Re: [VOTE] Rename clientSetUp() and clientTearDown() in
> > 1.5dev
> > >
> > > Personally I think clientSetUp and clientTearDown make more sense,
> > > assuming
> > > they work just like setUp and tearDown (once per test).
> >
> > ... yes, but Cactus has already extended JUnit by having beginXXX()
and
> > endXXX() methods that are executed on the client side. In other
words,
> > Cactus is "Junit-compliant" on the server side but the client side
is
> > purely Cactus-specific.
> >
> > As we already have beginXXX() and endXXX(), don't you think it looks
> > logical to have begin() and end() being global extensions (before
and
> > after each test) ?
> >
> > Thanks
> > -Vincent
> >
> > >
> > > -Pat
> > >
> > > ----- Original Message -----
> > > From: "Vincent Massol" <vm...@octo.com>
> > > To: <ca...@jakarta.apache.org>
> > > Cc: "'Cactus Users List'" <ca...@jakarta.apache.org>
> > > Sent: Thursday, August 01, 2002 10:56 AM
> > > Subject: [VOTE] Rename clientSetUp() and clientTearDown() in
1.5dev
> > >
> > >
> > > > Hi,
> > > >
> > > > Charles Massey has proposed on the 15th of July another name for
the
> > > > clientSetUp() and clientTearDown() methods : begin() and end().
> > > >
> > > > I think it is a better name than what we have and I propose to
make
> > the
> > > > change to begin() and end(). It is more logical as we already
have
> > > > beginXXX() and endXXX() methods.
> > > >
> > > > What do you think ?
> > > >
> > > > Here is my +1
> > > >
> > > > Thanks
> > > > -Vincent
> > > >
> > > >
> > > > --
> > > > To unsubscribe, e-mail:
> > > <ma...@jakarta.apache.org>
> > > > For additional commands, e-mail:
> > > <ma...@jakarta.apache.org>
> > > >
> > >
> > > --
> > > To unsubscribe, e-mail: <mailto:cactus-user-
> > > unsubscribe@jakarta.apache.org>
> > > For additional commands, e-mail: <mailto:cactus-user-
> > > help@jakarta.apache.org>
> >
--
To unsubscribe, e-mail: <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>
Re: [VOTE] Rename clientSetUp() and clientTearDown() in 1.5dev
Posted by Patrick Lightbody <pl...@hotmail.com>.
Well, since you put it that way... I see your point. My only concern is
confusion between beginXxx() and begin(), being that one is tied to an
individual test and the other is tied to the test suite, yet they both share
a common name.
-Pat
----- Original Message -----
From: "Vincent Massol" <vm...@octo.com>
To: "'Cactus Users List'" <ca...@jakarta.apache.org>
Cc: "'Patrick Lightbody'" <pl...@hotmail.com>
Sent: Thursday, August 01, 2002 6:43 PM
Subject: RE: [VOTE] Rename clientSetUp() and clientTearDown() in 1.5dev
>
>
> > -----Original Message-----
> > From: Patrick Lightbody [mailto:plightbo@hotmail.com]
> > Sent: 01 August 2002 11:11
> > To: Cactus Users List
> > Subject: Re: [VOTE] Rename clientSetUp() and clientTearDown() in
> 1.5dev
> >
> > Personally I think clientSetUp and clientTearDown make more sense,
> > assuming
> > they work just like setUp and tearDown (once per test).
>
> ... yes, but Cactus has already extended JUnit by having beginXXX() and
> endXXX() methods that are executed on the client side. In other words,
> Cactus is "Junit-compliant" on the server side but the client side is
> purely Cactus-specific.
>
> As we already have beginXXX() and endXXX(), don't you think it looks
> logical to have begin() and end() being global extensions (before and
> after each test) ?
>
> Thanks
> -Vincent
>
> >
> > -Pat
> >
> > ----- Original Message -----
> > From: "Vincent Massol" <vm...@octo.com>
> > To: <ca...@jakarta.apache.org>
> > Cc: "'Cactus Users List'" <ca...@jakarta.apache.org>
> > Sent: Thursday, August 01, 2002 10:56 AM
> > Subject: [VOTE] Rename clientSetUp() and clientTearDown() in 1.5dev
> >
> >
> > > Hi,
> > >
> > > Charles Massey has proposed on the 15th of July another name for the
> > > clientSetUp() and clientTearDown() methods : begin() and end().
> > >
> > > I think it is a better name than what we have and I propose to make
> the
> > > change to begin() and end(). It is more logical as we already have
> > > beginXXX() and endXXX() methods.
> > >
> > > What do you think ?
> > >
> > > Here is my +1
> > >
> > > Thanks
> > > -Vincent
> > >
> > >
> > > --
> > > To unsubscribe, e-mail:
> > <ma...@jakarta.apache.org>
> > > For additional commands, e-mail:
> > <ma...@jakarta.apache.org>
> > >
> >
> > --
> > To unsubscribe, e-mail: <mailto:cactus-user-
> > unsubscribe@jakarta.apache.org>
> > For additional commands, e-mail: <mailto:cactus-user-
> > help@jakarta.apache.org>
>
--
To unsubscribe, e-mail: <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>
RE: [VOTE] Rename clientSetUp() and clientTearDown() in 1.5dev
Posted by Vincent Massol <vm...@octo.com>.
> -----Original Message-----
> From: Patrick Lightbody [mailto:plightbo@hotmail.com]
> Sent: 01 August 2002 11:11
> To: Cactus Users List
> Subject: Re: [VOTE] Rename clientSetUp() and clientTearDown() in
1.5dev
>
> Personally I think clientSetUp and clientTearDown make more sense,
> assuming
> they work just like setUp and tearDown (once per test).
... yes, but Cactus has already extended JUnit by having beginXXX() and
endXXX() methods that are executed on the client side. In other words,
Cactus is "Junit-compliant" on the server side but the client side is
purely Cactus-specific.
As we already have beginXXX() and endXXX(), don't you think it looks
logical to have begin() and end() being global extensions (before and
after each test) ?
Thanks
-Vincent
>
> -Pat
>
> ----- Original Message -----
> From: "Vincent Massol" <vm...@octo.com>
> To: <ca...@jakarta.apache.org>
> Cc: "'Cactus Users List'" <ca...@jakarta.apache.org>
> Sent: Thursday, August 01, 2002 10:56 AM
> Subject: [VOTE] Rename clientSetUp() and clientTearDown() in 1.5dev
>
>
> > Hi,
> >
> > Charles Massey has proposed on the 15th of July another name for the
> > clientSetUp() and clientTearDown() methods : begin() and end().
> >
> > I think it is a better name than what we have and I propose to make
the
> > change to begin() and end(). It is more logical as we already have
> > beginXXX() and endXXX() methods.
> >
> > What do you think ?
> >
> > Here is my +1
> >
> > Thanks
> > -Vincent
> >
> >
> > --
> > To unsubscribe, e-mail:
> <ma...@jakarta.apache.org>
> > For additional commands, e-mail:
> <ma...@jakarta.apache.org>
> >
>
> --
> To unsubscribe, e-mail: <mailto:cactus-user-
> unsubscribe@jakarta.apache.org>
> For additional commands, e-mail: <mailto:cactus-user-
> help@jakarta.apache.org>
--
To unsubscribe, e-mail: <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>
Re: [VOTE] Rename clientSetUp() and clientTearDown() in 1.5dev
Posted by Patrick Lightbody <pl...@hotmail.com>.
Personally I think clientSetUp and clientTearDown make more sense, assuming
they work just like setUp and tearDown (once per test).
-Pat
----- Original Message -----
From: "Vincent Massol" <vm...@octo.com>
To: <ca...@jakarta.apache.org>
Cc: "'Cactus Users List'" <ca...@jakarta.apache.org>
Sent: Thursday, August 01, 2002 10:56 AM
Subject: [VOTE] Rename clientSetUp() and clientTearDown() in 1.5dev
> Hi,
>
> Charles Massey has proposed on the 15th of July another name for the
> clientSetUp() and clientTearDown() methods : begin() and end().
>
> I think it is a better name than what we have and I propose to make the
> change to begin() and end(). It is more logical as we already have
> beginXXX() and endXXX() methods.
>
> What do you think ?
>
> Here is my +1
>
> Thanks
> -Vincent
>
>
> --
> To unsubscribe, e-mail:
<ma...@jakarta.apache.org>
> For additional commands, e-mail:
<ma...@jakarta.apache.org>
>
--
To unsubscribe, e-mail: <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>
Re: [VOTE] Rename clientSetUp() and clientTearDown() in 1.5dev
Posted by Shane Duan <sd...@borland.com>.
I agree.
Vincent Massol wrote:
>Hi,
>
>Charles Massey has proposed on the 15th of July another name for the
>clientSetUp() and clientTearDown() methods : begin() and end().
>
>I think it is a better name than what we have and I propose to make the
>change to begin() and end(). It is more logical as we already have
>beginXXX() and endXXX() methods.
>
>What do you think ?
>
>Here is my +1
>
>Thanks
>-Vincent
>
>
>--
>To unsubscribe, e-mail: <ma...@jakarta.apache.org>
>For additional commands, e-mail: <ma...@jakarta.apache.org>
>
>
>
--
Disclaimer: I join all the news groups out of my own interest. All opinions expressed here are my own and not necessarily those of my employer.
Borland -- Enabling the digital world where our customers have the freedom of choice to develop, deploy, and integrate applications across the enterprise and the Internet. http://www.borland.com
This e-mail, and any attachments thereto, is intended only for use by the addressee(s) named herein and may contain legally privileged and/or confidential information. If you are not the intended recipient of this e-mail, you are hereby notified that any dissemination, distribution or copying of this e-mail, and any attachments thereto, is strictly prohibited. If you have received this e-mail in error, please immediately and permanently delete the original and any copy of any e-mail and any printout thereof.
--
To unsubscribe, e-mail: <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>