You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by "cqhasy (via GitHub)" <gi...@apache.org> on 2025/08/03 08:12:46 UTC
[PR] feat (add profile method for go agent) [skywalking-data-collect-protocol]
cqhasy opened a new pull request, #112:
URL: https://github.com/apache/skywalking-data-collect-protocol/pull/112
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat (add profile method for go agent) [skywalking-data-collect-protocol]
Posted by "wu-sheng (via GitHub)" <gi...@apache.org>.
wu-sheng commented on code in PR #112:
URL: https://github.com/apache/skywalking-data-collect-protocol/pull/112#discussion_r2266796818
##########
profile/Profile.proto:
##########
@@ -85,13 +85,10 @@ message ProfileTaskFinishReport {
// profile for go agent
message GoProfileData{
string taskId = 1;
- string traceSegmentId=2;
// the truly profile data
- bytes payload=3;
+ bytes payload=2;
Review Comment:
Please format these.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat (add profile method for go agent) [skywalking-data-collect-protocol]
Posted by "mrproliu (via GitHub)" <gi...@apache.org>.
mrproliu commented on code in PR #112:
URL: https://github.com/apache/skywalking-data-collect-protocol/pull/112#discussion_r2268337251
##########
profile/Profile.proto:
##########
@@ -36,7 +36,8 @@ service ProfileTask {
// collect dumped thread snapshot
rpc collectSnapshot (stream ThreadSnapshot) returns (Commands) {
}
-
+ // collect bytes profile data from go agent
+ rpc goProfileReport(stream GoProfileData)returns(Commands){}
Review Comment:
Please also format this line.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat (add profile method for go agent) [skywalking-data-collect-protocol]
Posted by "mrproliu (via GitHub)" <gi...@apache.org>.
mrproliu commented on code in PR #112:
URL: https://github.com/apache/skywalking-data-collect-protocol/pull/112#discussion_r2249750975
##########
profile/Profile.proto:
##########
@@ -80,3 +81,17 @@ message ProfileTaskFinishReport {
// profile task
string taskId = 3;
}
+
+// profile for go agent
+message GoProfileData{
+ string taskId = 1;
+ string traceSegmentId=2;
+ // the truly profile data
+ bytes payload=3;
+ // check last part true or false
+ bool isLast = 4;
+ // Span IDs with duration greater than minDuration,only in the last chunk
+ repeated int32 spanIds=5;
Review Comment:
When do you need to use this field? Could you more explain?
##########
profile/Profile.proto:
##########
@@ -80,3 +81,17 @@ message ProfileTaskFinishReport {
// profile task
string taskId = 3;
}
+
+// profile for go agent
+message GoProfileData{
+ string taskId = 1;
+ string traceSegmentId=2;
+ // the truly profile data
+ bytes payload=3;
+ // check last part true or false
+ bool isLast = 4;
+ // Span IDs with duration greater than minDuration,only in the last chunk
+ repeated int32 spanIds=5;
+ // use to reassemble fragments
+ int32 chunkId = 6;
Review Comment:
What does this field work for? You may send the profiling data without frequency, and sort by this field?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat (add profile method for go agent) [skywalking-data-collect-protocol]
Posted by "mrproliu (via GitHub)" <gi...@apache.org>.
mrproliu merged PR #112:
URL: https://github.com/apache/skywalking-data-collect-protocol/pull/112
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org