You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by achristianson <gi...@git.apache.org> on 2018/03/12 16:11:50 UTC
[GitHub] nifi-minifi-cpp pull request #275: Minificpp 414
GitHub user achristianson opened a pull request:
https://github.com/apache/nifi-minifi-cpp/pull/275
Minificpp 414
Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [x] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [x] Does your PR title start with MINIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [x] Has your PR been rebased against the latest commit within the target branch (typically master)?
- [x] Is your initial contribution a single, squashed commit?
### For code changes:
- [x] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [x] If applicable, have you updated the LICENSE file?
- [x] If applicable, have you updated the NOTICE file?
### For documentation related changes:
- [x] Have you ensured that format looks appropriate for the output in which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/achristianson/nifi-minifi-cpp MINIFICPP-414
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi-minifi-cpp/pull/275.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #275
----
commit 1b851e4668aeb3b3e6a3588ba22b60485052cf25
Author: Andrew I. Christianson <an...@...>
Date: 2018-03-09T17:56:37Z
MINIFICPP-422 Refactored type system in EL to preserve type information between operations
commit 11addb3114baae88b9b02c8c44d8b5cda6610554
Author: Andrew I. Christianson <an...@...>
Date: 2018-03-12T15:29:41Z
MINIFICPP-414 Added boolean Expression Language functions
----
---
[GitHub] nifi-minifi-cpp issue #275: MINIFICPP-414 Added boolean Expression Language ...
Posted by achristianson <gi...@git.apache.org>.
Github user achristianson commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/275
Rebased. I may have had the wrong commit pushed out there; didn't see any conflicts when I did the rebase onto master.
---
[GitHub] nifi-minifi-cpp issue #275: MINIFICPP-414 Added boolean Expression Language ...
Posted by achristianson <gi...@git.apache.org>.
Github user achristianson commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/275
This one depends wholly on MINIFICPP-422 and so cannot be separated from that commit.
---
[GitHub] nifi-minifi-cpp issue #275: MINIFICPP-414 Added boolean Expression Language ...
Posted by phrocker <gi...@git.apache.org>.
Github user phrocker commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/275
@achristianson I see conflicts. they may be easy to resolve, so i can take a look if need be.
---
[GitHub] nifi-minifi-cpp pull request #275: MINIFICPP-414 Added boolean Expression La...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/nifi-minifi-cpp/pull/275
---
[GitHub] nifi-minifi-cpp issue #275: MINIFICPP-414 Added boolean Expression Language ...
Posted by achristianson <gi...@git.apache.org>.
Github user achristianson commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/275
Fixed compiler errors. (Travis fail is due to a timeout on one build).
---