[GitHub] [opennlp] mawiesne commented on a diff in pull request #481: OPENNLP-1340 - Get the probability for a sequence without copying the probabilities

[GitBox <gi...@apache.org>]

mawiesne commented on code in PR #481:
URL: https://github.com/apache/opennlp/pull/481#discussion_r1060558324


##########
opennlp-tools/src/main/java/opennlp/tools/util/Sequence.java:
##########
@@ -122,7 +122,32 @@ public void add(String outcome, double p) {
    * @return Retrieves a list of outcomes for this {@link Sequence}.
    */
   public List<String> getOutcomes() {
-    return outcomes;
+    return List.copyOf(outcomes);
+  }
+
+  /**
+   * @return Retrieves the size of the outcomes for this {@link Sequence}.
+   */
+  public int getSize() {
+    return outcomes.size();
+  }
+
+  /**
+   * @param index must be greater than or equal to zero and must not exceed {@link Sequence#getSize()}.

Review Comment:
   Should read: ".. must be less than {@link Sequence#getSize()}"



##########
opennlp-tools/src/main/java/opennlp/tools/util/Sequence.java:
##########
@@ -122,7 +122,32 @@ public void add(String outcome, double p) {
    * @return Retrieves a list of outcomes for this {@link Sequence}.
    */
   public List<String> getOutcomes() {
-    return outcomes;
+    return List.copyOf(outcomes);
+  }
+
+  /**
+   * @return Retrieves the size of the outcomes for this {@link Sequence}.
+   */
+  public int getSize() {
+    return outcomes.size();
+  }
+
+  /**
+   * @param index must be greater than or equal to zero and must not exceed {@link Sequence#getSize()}.
+   * @return the outcome at the specified index.
+   * @throws IndexOutOfBoundsException thrown if the given index is out of range.
+   */
+  public String getOutcome(int index) {
+    return outcomes.get(index);
+  }
+
+  /**
+   * @param index must be greater than or equal to zero and must not exceed {@link Sequence#getSize()}.

Review Comment:
   Should read: ".. must be less than {@link Sequence#getSize()}"



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@opennlp.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org