You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/06/22 19:29:26 UTC

[GitHub] [airflow] dstandish commented on a diff in pull request #24356: Serialize pod_override to JSON before pickling executor_config

dstandish commented on code in PR #24356:
URL: https://github.com/apache/airflow/pull/24356#discussion_r904152772


##########
airflow/models/taskinstance.py:
##########
@@ -456,7 +461,7 @@ class TaskInstance(Base, LoggingMixin):
     queued_dttm = Column(UtcDateTime)
     queued_by_job_id = Column(Integer)
     pid = Column(Integer)
-    executor_config = Column(PickleType(pickler=dill, comparator=_executor_config_comparator))

Review Comment:
   hmm good point.  so this new ExecutorConfigType will store things using our serializer on a go-forward.  however, for stuff already stored in the DB, we could still encounter that attribute error when comparing.  so, probably we should continue to use that as the comparator.... what do you think?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org