[GitHub] [solr] Jdurham2843 commented on pull request #1126: SOLR-16462: Create v2 equivalent of v1 'CREATESNAPSHOT', 'LISTSNAPSHOT' and 'DELETESNAPSHOT' (core level)

[GitBox <gi...@apache.org>]

Jdurham2843 commented on PR #1126:
URL: https://github.com/apache/solr/pull/1126#issuecomment-1303901999

   1. Awesome, sounds good! The new syntax definitely looks better (and may be easier to parse if someone were using the API from another program), but it's probably a good idea to get consensus first.
   2. If we're still waiting on item 1, I'll go ahead and take a stab at it. Also, in reference to the your jira response, I'd be interested in working together on a more general solution too. It sounds like a good way to get familiar with other APIs in Solr.
   3. I added three tests just checking the errors response from CoreSnapshotAPI. I started to write some tests (heavily mocked) to verify the response output, but ran into an issue where I couldn't mock the IndexDeletionPolicyWrapper since its a final class. Are there any additional things you can think of that would be worth testing? My current thinking is that we're just trying to test/validate the interface (request, response, errors).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org