[PR] Fix empty labels in Stackdriver Log IO for Airflow 3 Supervisor [airflow]

["23tae (via GitHub)" <gi...@apache.org>]

23tae opened a new pull request, #68292:
URL: https://github.com/apache/airflow/pull/68292

    <!-- SPDX-License-Identifier: Apache-2.0
         https://www.apache.org/licenses/LICENSE-2.0 -->
   
   <!--
   Thank you for contributing!
   
   Please provide above a brief description of the changes made in this pull request.
   Write a good git commit message following this guide: http://chris.beams.io/posts/git-commit/
   
   Please make sure that your code changes are covered with tests.
   And in case of new features or big changes remember to adjust the documentation.
   
   Feel free to ping (in general) for the review if you do not see reaction for a few days
   (72 Hours is the minimum reaction time you can expect from volunteers) - we sometimes miss notifications.
   
   In case of an existing issue, reference it using one of the following:
   
   * closes: #ISSUE
   * related: #ISSUE
   -->
   
   This PR adds fallback logic to `StackdriverRemoteLogIO` to extract task labels directly from the `structlog` context dictionary when `record.task_instance` is missing, addressing the empty labels issue in the Airflow 3 Supervisor.
   
   ## Description
   This PR addresses **Bug 1** described in #68240.
   
   In the Airflow 3 Task SDK Supervisor environment, the `task_instance` object may be stripped from log records. Without it, the Stackdriver handler failed to attach identifying labels, resulting in untraceable "empty label" logs in Google Cloud.
   
   As suggested by @ashb in the issue, rather than manually parsing log file paths, this PR leverages the `structlog` context variables. The Task SDK inherently binds task details to the structlog context, making them naturally available in the `event` dictionary.
   
   ### Key changes
   * **Fallback Label Extraction**: Added fallback logic in `StackdriverRemoteLogIO.processors.proc`. If `record.task_instance` is missing, it safely extracts `dag_id`, `task_id`, `run_id`, `try_number`, and `map_index` directly from the `event` dictionary and applies them as labels.
   
   ## Verification Results
   I have verified the changes using `prek` and `breeze`.
   * **Static Checks (Prek):** Passed
   * **Unit Tests (Breeze):** Passed
   
   ---
   
   related: #68240
   
   ---
   
   ##### Was generative AI tooling used to co-author this PR?
   
   <!--
   If generative AI tooling has been used in the process of authoring this PR, please
   change below checkbox to `[X]` followed by the name of the tool, uncomment the "Generated-by".
   -->
   
   - [x] Yes
   
   Generated-by: Antigravity following [the guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#gen-ai-assisted-contributions)
   
   
   ---
   
   * Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)** for more information. Note: commit author/co-author name and email in commits become permanently public when merged.
   * For fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals)) is needed.
   * When adding dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
   * For significant user-facing changes create newsfragment: `{pr_number}.significant.rst`, in [airflow-core/newsfragments](https://github.com/apache/airflow/tree/main/airflow-core/newsfragments). You can add this file in a follow-up commit after the PR is created so you know the PR number.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Fix empty labels in Stackdriver log IO for Airflow 3 Supervisor [airflow]

["ashb (via GitHub)" <gi...@apache.org>]

ashb merged PR #68292:
URL: https://github.com/apache/airflow/pull/68292


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org