You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "zhangstar333 (via GitHub)" <gi...@apache.org> on 2024/01/15 10:09:10 UTC

[PR] [improve](column) support append_data_by_selector function in const column [doris]

zhangstar333 opened a new pull request, #29996:
URL: https://github.com/apache/doris/pull/29996

   ## Proposed changes
   
   Issue Number: close #xxx
   
   <!--Describe your changes.-->
   
   ## Further comments
   
   If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [improve](column) support append_data_by_selector function in const column [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #29996:
URL: https://github.com/apache/doris/pull/29996#issuecomment-1905299585

   
   Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   ```
   Load test result on commit 0c61dd9f4240e79544539e0a6cb9be950e3485e6 with default session variables
   Stream load json:         20 seconds loaded 2358488459 Bytes, about 112 MB/s
   Stream load orc:          58 seconds loaded 1101869774 Bytes, about 18 MB/s
   Stream load parquet:      31 seconds loaded 861443392 Bytes, about 26 MB/s
   Insert into select:       14.1 seconds inserted 10000000 Rows, about 709K ops/s
   ```
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [improve](column) support append_data_by_selector function in const column [doris]

Posted by "zhangstar333 (via GitHub)" <gi...@apache.org>.
zhangstar333 commented on PR #29996:
URL: https://github.com/apache/doris/pull/29996#issuecomment-1905243284

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [improve](column) support append_data_by_selector function in const column [doris]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #29996:
URL: https://github.com/apache/doris/pull/29996#issuecomment-1905249408

   PR approved by at least one committer and no changes requested.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [improve](column) support append_data_by_selector function in const column [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #29996:
URL: https://github.com/apache/doris/pull/29996#issuecomment-1891924390

   
   <details>
   <summary>TPC-H: <b>Total hot run time: 39889 ms</b></summary>
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
   Tpch sf100 test result on commit 348afea8a7765c7e27b583cc7accff034eead967, data reload: false
   
   ------ Round 1 ----------------------------------
   q1	17975	6870	5647	5647
   q2	2060	150	136	136
   q3	10845	1180	1225	1180
   q4	10502	811	844	811
   q5	7855	3119	3150	3119
   q6	204	127	126	126
   q7	904	510	503	503
   q8	9289	1990	2003	1990
   q9	7374	6479	6456	6456
   q10	8190	3136	3087	3087
   q11	415	215	214	214
   q12	367	197	202	197
   q13	18260	3445	3436	3436
   q14	258	220	217	217
   q15	566	515	510	510
   q16	446	404	374	374
   q17	964	538	520	520
   q18	7793	7155	6849	6849
   q19	1623	1425	1423	1423
   q20	582	291	306	291
   q21	2872	2509	2477	2477
   q22	389	326	335	326
   Total cold run time: 109733 ms
   Total hot run time: 39889 ms
   
   ----- Round 2, with runtime_filter_mode=off -----
   q1	5982	5588	5679	5588
   q2	361	227	221	221
   q3	3350	3214	3092	3092
   q4	2234	2135	2079	2079
   q5	5980	6077	6060	6060
   q6	209	122	125	122
   q7	2401	1929	1950	1929
   q8	3676	3765	3836	3765
   q9	9714	25147	9598	9598
   q10	4364	3870	3876	3870
   q11	676	469	446	446
   q12	1242	663	646	646
   q13	17118	3319	3239	3239
   q14	374	259	272	259
   q15	579	507	516	507
   q16	528	474	505	474
   q17	9194	2028	1841	1841
   q18	9714	9708	11617	9708
   q19	13669	1588	1594	1588
   q20	4217	1945	1941	1941
   q21	13828	5636	5754	5636
   q22	1168	606	591	591
   Total cold run time: 110578 ms
   Total hot run time: 63200 ms
   ```
   </details>
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [improve](column) support append_data_by_selector function in const column [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #29996:
URL: https://github.com/apache/doris/pull/29996#issuecomment-1905292252

   
   <details>
   <summary>TPC-DS: <b>Total hot run time: 176461 ms</b></summary>
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
   TPC-DS sf100 test result on commit 0c61dd9f4240e79544539e0a6cb9be950e3485e6, data reload: false
   
   query1	933	341	327	327
   query2	6555	2033	1908	1908
   query3	6718	202	195	195
   query4	32411	22128	22192	22128
   query5	4458	441	368	368
   query6	244	157	161	157
   query7	4604	259	285	259
   query8	219	171	179	171
   query9	8360	2548	2536	2536
   query10	412	257	258	257
   query11	16926	15625	15494	15494
   query12	121	69	64	64
   query13	1686	375	383	375
   query14	10686	7015	7012	7012
   query15	218	179	184	179
   query16	5795	261	251	251
   query17	943	474	468	468
   query18	1793	272	267	267
   query19	180	136	131	131
   query20	72	76	75	75
   query21	186	133	132	132
   query22	4821	4672	4700	4672
   query23	31863	30852	30816	30816
   query24	12663	2835	2764	2764
   query25	584	313	322	313
   query26	1813	150	151	150
   query27	3208	282	291	282
   query28	7290	1825	1799	1799
   query29	2172	633	651	633
   query30	287	141	134	134
   query31	948	733	740	733
   query32	80	51	50	50
   query33	706	216	216	216
   query34	1153	463	479	463
   query35	904	769	796	769
   query36	1257	1171	1136	1136
   query37	109	62	61	61
   query38	3322	3263	3234	3234
   query39	1311	1262	1267	1262
   query40	359	85	86	85
   query41	37	35	35	35
   query42	89	80	82	80
   query43	523	459	475	459
   query44	1123	686	687	686
   query45	193	181	176	176
   query46	1057	645	660	645
   query47	1626	1541	1529	1529
   query48	404	319	311	311
   query49	1215	290	292	290
   query50	705	312	322	312
   query51	5337	5134	5183	5134
   query52	90	77	74	74
   query53	318	270	255	255
   query54	246	195	204	195
   query55	82	79	76	76
   query56	180	172	165	165
   query57	1014	923	919	919
   query58	185	165	166	165
   query59	2733	2670	2681	2670
   query60	202	183	188	183
   query61	85	83	83	83
   query62	608	364	361	361
   query63	286	254	267	254
   query64	6179	1785	1782	1782
   query65	3350	3275	3272	3272
   query66	1411	317	310	310
   query67	15494	15281	15042	15042
   query68	11363	545	506	506
   query69	611	315	309	309
   query70	1601	1498	1383	1383
   query71	563	211	222	211
   query72	4905	2847	2886	2847
   query73	2122	321	316	316
   query74	7097	6327	6406	6327
   query75	4780	2271	2353	2271
   query76	6762	1026	1102	1026
   query77	733	233	232	232
   query78	9603	8780	8604	8604
   query79	999	495	505	495
   query80	566	327	320	320
   query81	449	207	203	203
   query82	199	84	77	77
   query83	141	124	116	116
   query84	278	70	68	68
   query85	1075	353	336	336
   query86	380	375	397	375
   query87	3485	3456	3354	3354
   query88	2977	2205	2183	2183
   query89	426	366	358	358
   query90	1971	190	188	188
   query91	168	129	128	128
   query92	53	47	45	45
   query93	1072	439	418	418
   query94	1227	165	158	158
   query95	501	479	457	457
   query96	616	321	316	316
   query97	4255	4148	4183	4148
   query98	202	198	190	190
   query99	1052	707	721	707
   Total cold run time: 295374 ms
   Total hot run time: 176461 ms
   ```
   </details>
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [improve](column) support append_data_by_selector function in const column [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #29996:
URL: https://github.com/apache/doris/pull/29996#issuecomment-1891959934

   
   <details>
   <summary>TPC-DS: <b>Total hot run time: 179455 ms</b></summary>
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
   TPC-DS sf100 test result on commit 348afea8a7765c7e27b583cc7accff034eead967, data reload: false
   
   query1	938	338	329	329
   query2	6742	1900	1765	1765
   query3	6702	207	201	201
   query4	34133	22330	22095	22095
   query5	6953	564	550	550
   query6	257	188	190	188
   query7	4619	296	278	278
   query8	246	193	192	192
   query9	9199	2805	2790	2790
   query10	561	240	245	240
   query11	16762	15510	15243	15243
   query12	119	70	71	70
   query13	1689	371	389	371
   query14	11324	7343	7587	7343
   query15	211	195	197	195
   query16	4625	273	259	259
   query17	977	493	492	492
   query18	1797	276	264	264
   query19	182	151	146	146
   query20	84	78	75	75
   query21	198	136	128	128
   query22	4947	4838	4846	4838
   query23	31902	31206	31236	31206
   query24	12284	2841	2838	2838
   query25	581	334	332	332
   query26	1840	155	153	153
   query27	3255	281	279	279
   query28	7231	1879	1861	1861
   query29	2124	715	681	681
   query30	284	140	139	139
   query31	945	761	764	761
   query32	77	61	60	60
   query33	713	254	244	244
   query34	1135	479	475	475
   query35	890	838	755	755
   query36	1422	1234	1312	1234
   query37	105	69	72	69
   query38	3372	3295	3289	3289
   query39	1342	1282	1289	1282
   query40	344	99	97	97
   query41	38	36	37	36
   query42	109	94	93	93
   query43	539	514	471	471
   query44	1127	710	721	710
   query45	204	182	189	182
   query46	1057	631	641	631
   query47	1711	1594	1562	1562
   query48	416	327	316	316
   query49	1247	313	307	307
   query50	714	319	321	319
   query51	5394	5205	5226	5205
   query52	107	93	97	93
   query53	356	293	296	293
   query54	887	460	464	460
   query55	88	94	86	86
   query56	215	190	196	190
   query57	1028	976	967	967
   query58	209	199	199	199
   query59	2895	2674	2658	2658
   query60	247	245	226	226
   query61	88	86	91	86
   query62	666	415	399	399
   query63	310	309	286	286
   query64	6343	1681	1668	1668
   query65	3388	3280	3292	3280
   query66	1400	322	325	322
   query67	15738	15471	15366	15366
   query68	11899	508	516	508
   query69	650	346	356	346
   query70	1767	1580	1473	1473
   query71	540	246	251	246
   query72	5002	2859	2816	2816
   query73	2816	310	326	310
   query74	6971	6500	6532	6500
   query75	5123	2369	2307	2307
   query76	6312	992	1037	992
   query77	665	277	279	277
   query78	9180	8723	8587	8587
   query79	3623	496	527	496
   query80	560	354	353	353
   query81	448	206	210	206
   query82	248	89	93	89
   query83	154	120	125	120
   query84	276	71	71	71
   query85	1058	339	331	331
   query86	389	416	380	380
   query87	3518	3401	3465	3401
   query88	3497	2226	2221	2221
   query89	478	398	377	377
   query90	2019	204	201	201
   query91	159	128	132	128
   query92	61	59	54	54
   query93	2470	433	424	424
   query94	1207	181	182	181
   query95	535	496	476	476
   query96	638	325	314	314
   query97	4263	4163	4159	4159
   query98	213	203	187	187
   query99	1082	715	706	706
   Total cold run time: 307453 ms
   Total hot run time: 179455 ms
   ```
   </details>
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [improve](column) support append_data_by_selector function in const column [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #29996:
URL: https://github.com/apache/doris/pull/29996#issuecomment-1891977175

   
   <details>
   <summary>ClickBench: <b>Total hot run time: 30.25 s</b></summary>
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
   ClickBench test result on commit 348afea8a7765c7e27b583cc7accff034eead967, data reload: false
   
   query1	0.05	0.06	0.06
   query2	0.06	0.03	0.03
   query3	0.24	0.12	0.11
   query4	1.78	0.11	0.13
   query5	0.53	0.52	0.52
   query6	1.34	0.65	0.64
   query7	0.02	0.02	0.01
   query8	0.04	0.02	0.02
   query9	0.56	0.51	0.50
   query10	0.57	0.57	0.56
   query11	0.12	0.10	0.09
   query12	0.12	0.09	0.08
   query13	0.60	0.60	0.60
   query14	0.77	0.79	0.80
   query15	0.80	0.77	0.79
   query16	0.40	0.40	0.39
   query17	1.02	1.02	1.00
   query18	0.26	0.25	0.26
   query19	1.88	1.80	1.80
   query20	0.01	0.01	0.01
   query21	15.41	0.58	0.58
   query22	2.49	3.35	1.80
   query23	17.23	0.96	0.72
   query24	2.51	1.64	0.17
   query25	0.35	0.18	0.22
   query26	0.45	0.15	0.14
   query27	0.06	0.06	0.04
   query28	11.62	0.79	0.78
   query29	12.61	3.23	3.21
   query30	0.53	0.49	0.49
   query31	2.78	0.34	0.36
   query32	3.38	0.48	0.48
   query33	3.24	3.20	3.26
   query34	16.21	4.24	4.22
   query35	4.20	4.24	4.25
   query36	1.12	1.09	1.07
   query37	0.06	0.05	0.05
   query38	0.04	0.03	0.02
   query39	0.02	0.01	0.01
   query40	0.16	0.13	0.13
   query41	0.07	0.01	0.02
   query42	0.03	0.02	0.01
   query43	0.02	0.02	0.02
   Total cold run time: 105.76 s
   Total hot run time: 30.25 s
   ```
   </details>
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [improve](column) support append_data_by_selector function in const column [doris]

Posted by "BiteTheDDDDt (via GitHub)" <gi...@apache.org>.
BiteTheDDDDt merged PR #29996:
URL: https://github.com/apache/doris/pull/29996


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [improve](column) support append_data_by_selector function in const column [doris]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #29996:
URL: https://github.com/apache/doris/pull/29996#issuecomment-1891802733

   clang-tidy review says "All clean, LGTM! :+1:"


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [improve](column) support append_data_by_selector function in const column [doris]

Posted by "HappenLee (via GitHub)" <gi...@apache.org>.
HappenLee commented on code in PR #29996:
URL: https://github.com/apache/doris/pull/29996#discussion_r1462686054


##########
be/src/vec/columns/column_const.h:
##########
@@ -225,7 +225,7 @@ class ColumnConst final : public COWHelper<IColumn, ColumnConst> {
 
     void append_data_by_selector(MutableColumnPtr& res,
                                  const IColumn::Selector& selector) const override {
-        LOG(FATAL) << "append_data_by_selector is not supported in ColumnConst!";
+        this->template append_data_by_selector_impl<Self>(res, selector);

Review Comment:
   better resize the column,no need `insert_from`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [improve](column) support append_data_by_selector function in const column [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #29996:
URL: https://github.com/apache/doris/pull/29996#issuecomment-1905297477

   
   <details>
   <summary>ClickBench: <b>Total hot run time: 29.83 s</b></summary>
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
   ClickBench test result on commit 0c61dd9f4240e79544539e0a6cb9be950e3485e6, data reload: false
   
   query1	0.03	0.03	0.03
   query2	0.06	0.03	0.03
   query3	0.23	0.05	0.06
   query4	1.69	0.08	0.08
   query5	0.54	0.53	0.52
   query6	1.28	0.62	0.63
   query7	0.02	0.01	0.01
   query8	0.03	0.02	0.02
   query9	0.55	0.50	0.50
   query10	0.56	0.57	0.56
   query11	0.12	0.09	0.08
   query12	0.11	0.09	0.10
   query13	0.59	0.60	0.59
   query14	0.78	0.83	0.80
   query15	0.80	0.79	0.76
   query16	0.36	0.36	0.37
   query17	1.00	0.97	1.00
   query18	0.23	0.26	0.25
   query19	1.86	1.78	1.74
   query20	0.01	0.00	0.01
   query21	15.40	0.60	0.61
   query22	2.38	3.02	1.30
   query23	17.25	0.91	0.80
   query24	2.35	0.73	0.45
   query25	0.42	0.28	0.09
   query26	0.32	0.13	0.13
   query27	0.07	0.07	0.04
   query28	12.25	0.77	0.76
   query29	12.55	3.22	3.17
   query30	0.50	0.56	0.48
   query31	2.77	0.35	0.34
   query32	3.39	0.50	0.48
   query33	3.20	3.28	3.26
   query34	16.10	4.32	4.34
   query35	4.35	4.35	4.26
   query36	1.13	1.06	1.07
   query37	0.06	0.04	0.05
   query38	0.04	0.03	0.03
   query39	0.02	0.02	0.01
   query40	0.16	0.13	0.12
   query41	0.06	0.02	0.01
   query42	0.03	0.01	0.02
   query43	0.02	0.01	0.02
   Total cold run time: 105.67 s
   Total hot run time: 29.83 s
   ```
   </details>
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [improve](column) support append_data_by_selector function in const column [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #29996:
URL: https://github.com/apache/doris/pull/29996#issuecomment-1905291028

   TeamCity be ut coverage result:
    Function Coverage: 36.68% (8664/23621) 
    Line Coverage: 28.72% (70724/246276)
    Region Coverage: 27.60% (36449/132080)
    Branch Coverage: 24.33% (18654/76670)
    Coverage Report: http://coverage.selectdb-in.cc/coverage/0c61dd9f4240e79544539e0a6cb9be950e3485e6_0c61dd9f4240e79544539e0a6cb9be950e3485e6/report/index.html


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [improve](column) support append_data_by_selector function in const column [doris]

Posted by "zhangstar333 (via GitHub)" <gi...@apache.org>.
zhangstar333 commented on PR #29996:
URL: https://github.com/apache/doris/pull/29996#issuecomment-1891790538

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [improve](column) support append_data_by_selector function in const column [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #29996:
URL: https://github.com/apache/doris/pull/29996#issuecomment-1891961116

   (From new machine)TeamCity pipeline, clickbench performance test result:
    the sum of best hot time: 46.21 seconds
    stream load tsv:          567 seconds loaded 74807831229 Bytes, about 125 MB/s
    stream load json:         19 seconds loaded 2358488459 Bytes, about 118 MB/s
    stream load orc:          65 seconds loaded 1101869774 Bytes, about 16 MB/s
    stream load parquet:          32 seconds loaded 861443392 Bytes, about 25 MB/s
    insert into select:          21.1 seconds inserted 10000000 Rows, about 473K ops/s
    storage size: 17183883868 Bytes


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [improve](column) support append_data_by_selector function in const column [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #29996:
URL: https://github.com/apache/doris/pull/29996#issuecomment-1891964258

   TeamCity be ut coverage result:
    Function Coverage: 36.68% (8648/23576) 
    Line Coverage: 28.71% (70462/245451)
    Region Coverage: 27.62% (36418/131836)
    Branch Coverage: 24.35% (18636/76522)
    Coverage Report: http://coverage.selectdb-in.cc/coverage/348afea8a7765c7e27b583cc7accff034eead967_348afea8a7765c7e27b583cc7accff034eead967/report/index.html


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [improve](column) support append_data_by_selector function in const column [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #29996:
URL: https://github.com/apache/doris/pull/29996#issuecomment-1891984518

   
   Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   ```
   Load test result on commit 348afea8a7765c7e27b583cc7accff034eead967 with default session variables
   Stream load json:         19 seconds loaded 2358488459 Bytes, about 118 MB/s
   Stream load orc:          58 seconds loaded 1101869774 Bytes, about 18 MB/s
   Stream load parquet:      31 seconds loaded 861443392 Bytes, about 26 MB/s
   Insert into select:       14.8 seconds inserted 10000000 Rows, about 675K ops/s
   ```
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [improve](column) support append_data_by_selector function in const column [doris]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #29996:
URL: https://github.com/apache/doris/pull/29996#issuecomment-1905249434

   PR approved by anyone and no changes requested.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [improve](column) support append_data_by_selector function in const column [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #29996:
URL: https://github.com/apache/doris/pull/29996#issuecomment-1905284907

   
   <details>
   <summary>TPC-H: <b>Total hot run time: 39290 ms</b></summary>
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
   Tpch sf100 test result on commit 0c61dd9f4240e79544539e0a6cb9be950e3485e6, data reload: false
   
   ------ Round 1 ----------------------------------
   q1	18818	5823	5430	5430
   q2	2631	155	133	133
   q3	11658	1201	1184	1184
   q4	10699	766	821	766
   q5	8068	3273	3275	3273
   q6	208	125	128	125
   q7	893	516	496	496
   q8	9451	1992	2026	1992
   q9	7287	6414	6389	6389
   q10	8193	3080	3067	3067
   q11	418	222	205	205
   q12	361	194	200	194
   q13	17983	3363	3374	3363
   q14	245	214	213	213
   q15	548	502	505	502
   q16	435	371	376	371
   q17	960	530	541	530
   q18	7525	6685	6987	6685
   q19	3239	1364	1366	1364
   q20	583	307	280	280
   q21	2800	2410	2448	2410
   q22	371	328	318	318
   Total cold run time: 113374 ms
   Total hot run time: 39290 ms
   
   ----- Round 2, with runtime_filter_mode=off -----
   q1	5415	5293	5427	5293
   q2	323	218	216	216
   q3	3388	3289	3277	3277
   q4	2095	2033	2043	2033
   q5	5965	5856	5950	5856
   q6	200	118	122	118
   q7	2229	1931	1825	1825
   q8	3238	3394	3427	3394
   q9	8912	9009	8857	8857
   q10	4987	3821	3871	3821
   q11	706	439	452	439
   q12	806	619	596	596
   q13	16988	3171	3153	3153
   q14	292	255	262	255
   q15	565	510	511	510
   q16	515	455	459	455
   q17	4211	1871	1901	1871
   q18	9468	9205	9606	9205
   q19	21990	1528	1483	1483
   q20	4623	1947	1920	1920
   q21	14166	5368	5442	5368
   q22	990	545	585	545
   Total cold run time: 112072 ms
   Total hot run time: 60490 ms
   ```
   </details>
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org