You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@texera.apache.org by "aglinxinyuan (via GitHub)" <gi...@apache.org> on 2026/09/29 03:23:31 UTC
[PR] refactor(frontend): remove dead hub workflow detail markup [texera]
aglinxinyuan opened a new pull request, #8748:
URL: https://github.com/apache/texera/pull/8748
### What changes were proposed in this PR?
Removes two leftovers from `HubWorkflowDetailComponent`. **−17 lines.** There is no behaviour change.
- **Template:** the empty `<ng-template #codeEditor></ng-template>`. Nothing reads it: the component has no `@ViewChild`, and the only other `#codeEditor` in the app is the live one in `workspace.component.html`.
- **Styles:** the `.workflow-steps`, `.workflow-step`, `.workflow-step h3` and `.workflow-step p` rules, which no markup uses.
### History
| | |
| --- | --- |
| **Introduced by** | #2725 (2024-09-24), "Add Hub": the step styles. #2873 (2024-09-27), "Add workflow preview to hub details page": the `#codeEditor` anchor |
| **Usage removed by** | #3006 (2024-11-05), "Remove home page and step from the detail page": the step markup. #3007 (2024-11-05), "Fix sharing issue of hub preview": the `@ViewChild("codeEditor")` that read the anchor |
Both have been dead for nearly two years.
### Any related issues, documentation, discussions?
Closes #8747
### How was this PR tested?
No new tests.
From `frontend/`:
- `npx ng test --watch=false --include='**/hub-workflow-detail.component.spec.ts' --include='**/card-item.component.spec.ts' --include='**/list-item.component.spec.ts' --include='**/workspace.component.spec.ts'`: 4 files, 221 tests, all pass. The card-item and list-item specs open this component in a modal, and the workspace spec owns the live `#codeEditor`.
- `yarn format:ci`: clean.
- `npx ng build`: success.
To re-check:
```
git grep -n "workflow-step" -- frontend # no hits
```
### Was this PR authored or co-authored using generative AI tooling?
Generated-by: Claude Code (Claude Opus 5.5)
🤖 Generated with [Claude Code](https://claude.com/claude-code)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] refactor(frontend): remove dead hub workflow detail markup [texera]
Posted by "aglinxinyuan (via GitHub)" <gi...@apache.org>.
aglinxinyuan merged PR #8748:
URL: https://github.com/apache/texera/pull/8748
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] refactor(frontend): remove dead hub workflow detail markup [texera]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #8748:
URL: https://github.com/apache/texera/pull/8748#issuecomment-5883022025
<!-- texera-reviewer-suggestion -->
### Automated Reviewer Suggestions
Based on the `git blame` history of the changed files, we recommend the following reviewers:
- **Contributors with relevant context:** `@xuang7`
You can notify them by mentioning `@xuang7` in a comment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] refactor(frontend): remove dead hub workflow detail markup [texera]
Posted by "kunwp1 (via GitHub)" <gi...@apache.org>.
kunwp1 commented on code in PR #8748:
URL: https://github.com/apache/texera/pull/8748#discussion_r4188968368
##########
frontend/src/app/hub/component/workflow/detail/hub-workflow-detail.component.scss:
##########
Review Comment:
This seems to be a dead code too. Can you check?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] refactor(frontend): remove dead hub workflow detail markup [texera]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #8748:
URL: https://github.com/apache/texera/pull/8748#issuecomment-6004040893
## [Codecov](https://app.codecov.io/gh/apache/texera/pull/8748?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 92.60%. Comparing base ([`acc6dd1`](https://app.codecov.io/gh/apache/texera/commit/acc6dd1139d936d849e2aaa6abb288f8ef3e98ad?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`024f810`](https://app.codecov.io/gh/apache/texera/commit/024f8109f2b50ec310ce3a9c759706115271dba5?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 20 commits behind head on main.
:white_check_mark: All tests successful. No failed tests found.
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## main #8748 +/- ##
=========================================
Coverage 92.59% 92.60%
Complexity 4962 4962
=========================================
Files 1242 1245 +3
Lines 52883 52963 +80
Branches 6546 6574 +28
=========================================
+ Hits 48965 49044 +79
Misses 2290 2290
- Partials 1628 1629 +1
```
| [Flag](https://app.codecov.io/gh/apache/texera/pull/8748/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | *Carryforward flag |
|---|---|---|---|
| [access-control-service](https://app.codecov.io/gh/apache/texera/pull/8748/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `77.38% <ø> (ø)` | | Carriedforward from [5d31ff7](https://app.codecov.io/gh/apache/texera/commit/5d31ff77106c92febe1ec8747bf77ca07f7ebf5f?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [agent-service](https://app.codecov.io/gh/apache/texera/pull/8748/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `99.16% <ø> (ø)` | | Carriedforward from [5d31ff7](https://app.codecov.io/gh/apache/texera/commit/5d31ff77106c92febe1ec8747bf77ca07f7ebf5f?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [amber](https://app.codecov.io/gh/apache/texera/pull/8748/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `88.06% <ø> (ø)` | | Carriedforward from [5d31ff7](https://app.codecov.io/gh/apache/texera/commit/5d31ff77106c92febe1ec8747bf77ca07f7ebf5f?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [computing-unit-managing-service](https://app.codecov.io/gh/apache/texera/pull/8748/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `60.41% <ø> (ø)` | | Carriedforward from [5d31ff7](https://app.codecov.io/gh/apache/texera/commit/5d31ff77106c92febe1ec8747bf77ca07f7ebf5f?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [config-service](https://app.codecov.io/gh/apache/texera/pull/8748/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `87.37% <ø> (ø)` | | Carriedforward from [5d31ff7](https://app.codecov.io/gh/apache/texera/commit/5d31ff77106c92febe1ec8747bf77ca07f7ebf5f?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [file-service](https://app.codecov.io/gh/apache/texera/pull/8748/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `81.53% <ø> (ø)` | | Carriedforward from [5d31ff7](https://app.codecov.io/gh/apache/texera/commit/5d31ff77106c92febe1ec8747bf77ca07f7ebf5f?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [frontend](https://app.codecov.io/gh/apache/texera/pull/8748/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `96.56% <ø> (+<0.01%)` | :arrow_up: | |
| [notebook-migration-service](https://app.codecov.io/gh/apache/texera/pull/8748/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `83.73% <ø> (ø)` | | Carriedforward from [5d31ff7](https://app.codecov.io/gh/apache/texera/commit/5d31ff77106c92febe1ec8747bf77ca07f7ebf5f?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [pyamber](https://app.codecov.io/gh/apache/texera/pull/8748/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `98.56% <ø> (ø)` | | Carriedforward from [5d31ff7](https://app.codecov.io/gh/apache/texera/commit/5d31ff77106c92febe1ec8747bf77ca07f7ebf5f?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [workflow-compiling-service](https://app.codecov.io/gh/apache/texera/pull/8748/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `74.09% <ø> (ø)` | | Carriedforward from [5d31ff7](https://app.codecov.io/gh/apache/texera/commit/5d31ff77106c92febe1ec8747bf77ca07f7ebf5f?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
*This pull request uses carry forward flags. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) to find out more.
</details>
[:umbrella: View full report in Codecov by Harness](https://app.codecov.io/gh/apache/texera/pull/8748?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
<details><summary> :rocket: New features to boost your workflow: </summary>
- :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] refactor(frontend): remove dead hub workflow detail markup [texera]
Posted by "aglinxinyuan (via GitHub)" <gi...@apache.org>.
aglinxinyuan commented on code in PR #8748:
URL: https://github.com/apache/texera/pull/8748#discussion_r4189025639
##########
frontend/src/app/hub/component/workflow/detail/hub-workflow-detail.component.scss:
##########
Review Comment:
Good catch, it is dead. Under the default emulated encapsulation Angular compiles it to `body[_ngcontent-…]`, and the document `<body>` (static in `index.html`) never carries that attribute, so the rule has never matched anything since #2725 added it. Removed in 024f8109f2. I also checked the remaining rules in this file: each one matches an element in the template.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org