You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2020/02/29 03:58:04 UTC
[kudu-CR] [mini-cluster] clean up on common flags
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/15325
Change subject: [mini-cluster] clean up on common flags
......................................................................
[mini-cluster] clean up on common flags
This patch moves the operations with the subset of --fs_wal_dir,
--fs_data_dirs, and --block_manager common flags into
ExternalDaemon::StartProcess() method. Other unsorted re-factoring.
This patch doesn't contain any functional modifications.
Change-Id: Ic0a3e14d75ccd9062a2813b1c9421f569a3cc94d
---
M src/kudu/mini-cluster/external_mini_cluster.cc
M src/kudu/mini-cluster/external_mini_cluster.h
2 files changed, 90 insertions(+), 98 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/25/15325/1
--
To view, visit http://gerrit.cloudera.org:8080/15325
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic0a3e14d75ccd9062a2813b1c9421f569a3cc94d
Gerrit-Change-Number: 15325
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
[kudu-CR] [mini-cluster] clean up on common flags
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/15325 )
Change subject: [mini-cluster] clean up on common flags
......................................................................
Patch Set 1: Verified+1
unrelated tests failures already tracked as:
* https://issues.apache.org/jira/browse/KUDU-2999
* https://issues.apache.org/jira/browse/KUDU-3039
--
To view, visit http://gerrit.cloudera.org:8080/15325
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic0a3e14d75ccd9062a2813b1c9421f569a3cc94d
Gerrit-Change-Number: 15325
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Volodymyr Verovkin <ve...@cloudera.com>
Gerrit-Comment-Date: Sat, 29 Feb 2020 05:00:31 +0000
Gerrit-HasComments: No
[kudu-CR] [mini-cluster] clean up on common flags
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15325 )
Change subject: [mini-cluster] clean up on common flags
......................................................................
[mini-cluster] clean up on common flags
This patch moves the operations with the subset of --fs_wal_dir,
--fs_data_dirs, and --block_manager common flags into
ExternalDaemon::StartProcess() method. Other unsorted re-factoring.
This patch doesn't contain any functional modifications.
Change-Id: Ic0a3e14d75ccd9062a2813b1c9421f569a3cc94d
Reviewed-on: http://gerrit.cloudera.org:8080/15325
Tested-by: Alexey Serbin <as...@cloudera.com>
Reviewed-by: Adar Dembo <ad...@cloudera.com>
---
M src/kudu/mini-cluster/external_mini_cluster.cc
M src/kudu/mini-cluster/external_mini_cluster.h
2 files changed, 90 insertions(+), 98 deletions(-)
Approvals:
Alexey Serbin: Verified
Adar Dembo: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/15325
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic0a3e14d75ccd9062a2813b1c9421f569a3cc94d
Gerrit-Change-Number: 15325
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Volodymyr Verovkin <ve...@cloudera.com>
[kudu-CR] [mini-cluster] clean up on common flags
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15325 )
Change subject: [mini-cluster] clean up on common flags
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/15325
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic0a3e14d75ccd9062a2813b1c9421f569a3cc94d
Gerrit-Change-Number: 15325
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Volodymyr Verovkin <ve...@cloudera.com>
Gerrit-Comment-Date: Tue, 03 Mar 2020 04:20:21 +0000
Gerrit-HasComments: No
[kudu-CR] [mini-cluster] clean up on common flags
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has removed a vote on this change.
Change subject: [mini-cluster] clean up on common flags
......................................................................
Removed Verified-1 by Kudu Jenkins (120)
--
To view, visit http://gerrit.cloudera.org:8080/15325
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: Ic0a3e14d75ccd9062a2813b1c9421f569a3cc94d
Gerrit-Change-Number: 15325
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Volodymyr Verovkin <ve...@cloudera.com>