You are viewing a plain text version of this content. The canonical link for it is here.
Posted to mapreduce-issues@hadoop.apache.org by "Szilard Nemeth (JIRA)" <ji...@apache.org> on 2019/08/02 11:55:00 UTC
[jira] [Updated] (MAPREDUCE-7197) Fix order of actual and expected
expression in assert statements
[ https://issues.apache.org/jira/browse/MAPREDUCE-7197?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Szilard Nemeth updated MAPREDUCE-7197:
--------------------------------------
Attachment: MAPREDUCE-7197.004.patch
> Fix order of actual and expected expression in assert statements
> ----------------------------------------------------------------
>
> Key: MAPREDUCE-7197
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-7197
> Project: Hadoop Map/Reduce
> Issue Type: Improvement
> Affects Versions: 3.2.0
> Reporter: Adam Antal
> Assignee: Adam Antal
> Priority: Major
> Attachments: MAPREDUCE-7197.001.patch, MAPREDUCE-7197.002.patch, MAPREDUCE-7197.003.patch, MAPREDUCE-7197.004.patch, MAPREDUCE-7197.004.patch, old-approx-from-HADOOP-12693
>
>
> Fix order of actual and expected expression in assert statements which gives misleading message when test case fails. Attached file has some of the places where it is placed wrongly.
> {code:java}
> [ERROR] testNodeRemovalGracefully(org.apache.hadoop.yarn.server.resourcemanager.TestResourceTrackerService) Time elapsed: 3.385 s <<< FAILURE!
> java.lang.AssertionError: Shutdown nodes should be 0 now expected:<1> but was:<0>
> {code}
> For long term, [AssertJ|http://joel-costigliola.github.io/assertj/] can be used for new test cases which avoids such mistakes.
> This is a follow-up Jira on the fix for the MR project.
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
---------------------------------------------------------------------
To unsubscribe, e-mail: mapreduce-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: mapreduce-issues-help@hadoop.apache.org