You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by thenatog <gi...@git.apache.org> on 2018/08/31 14:42:52 UTC
[GitHub] nifi pull request #2982: NIFI-4558 - Set JKS as the default keystore type an...
GitHub user thenatog opened a pull request:
https://github.com/apache/nifi/pull/2982
NIFI-4558 - Set JKS as the default keystore type and truststore type.
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [x] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [x] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [x] Has your PR been rebased against the latest commit within the target branch (typically master)?
- [x] Is your initial contribution a single, squashed commit?
### For code changes:
- [x] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
- [ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
- [ ] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/thenatog/nifi NIFI-4558
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi/pull/2982.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2982
----
commit 2b9fdf8415eb2b033bfc63a6c5254bba3e69ecdd
Author: thenatog <th...@...>
Date: 2018-08-31T14:17:28Z
NIFI-4558 - Set JKS as the default keystore type and truststore type.
----
---
[GitHub] nifi issue #2982: NIFI-4558 - Set JKS as the default keystore type and trust...
Posted by alopresto <gi...@git.apache.org>.
Github user alopresto commented on the issue:
https://github.com/apache/nifi/pull/2982
Reviewing...
---
[GitHub] nifi issue #2982: NIFI-4558 - Set JKS as the default keystore type and trust...
Posted by alopresto <gi...@git.apache.org>.
Github user alopresto commented on the issue:
https://github.com/apache/nifi/pull/2982
Verified that this sets the defaults to "JKS" for both keystore and truststore on `StandardSSLContextService` and `StandardRestrictedSSLContextService`.
Ran `contrib-check` and all tests pass. +1, merging.
---
[GitHub] nifi pull request #2982: NIFI-4558 - Set JKS as the default keystore type an...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/nifi/pull/2982
---