You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by je...@apache.org on 2020/10/02 02:54:05 UTC

[incubator-nuttx] branch master updated: arch: cxd56xx: Fix handle_irqreq() in cxd56_cpupause.c

This is an automated email from the ASF dual-hosted git repository.

jerpelea pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git


The following commit(s) were added to refs/heads/master by this push:
     new 3f461f5  arch: cxd56xx: Fix handle_irqreq() in cxd56_cpupause.c
3f461f5 is described below

commit 3f461f59ba15ba261c85f72d8db23c35b2ec90d7
Author: Masayuki Ishikawa <ma...@gmail.com>
AuthorDate: Fri Oct 2 08:36:26 2020 +0900

    arch: cxd56xx: Fix handle_irqreq() in cxd56_cpupause.c
    
    Summary:
    - The handle_irqreq() is used for remote IRQ control.
    - The logic is called via IPI (Inter-Processor Interrupt)
    - And the handler should handle only one request
    - However, I noticed that the handler handles up to two requests
    - This commit fixes this issue
    
    Impact:
    - Affects SMP cases only
    
    Testing:
    - Tested with spresense:wifi_smp
    
    Signed-off-by: Masayuki Ishikawa <Ma...@jp.sony.com>
---
 arch/arm/src/cxd56xx/cxd56_cpupause.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/arch/arm/src/cxd56xx/cxd56_cpupause.c b/arch/arm/src/cxd56xx/cxd56_cpupause.c
index b3480bb..89b296b 100644
--- a/arch/arm/src/cxd56xx/cxd56_cpupause.c
+++ b/arch/arm/src/cxd56xx/cxd56_cpupause.c
@@ -149,6 +149,8 @@ static bool handle_irqreq(int cpu)
 
           spin_unlock(&g_cpu_wait[cpu]);
           handled = true;
+
+          break;
         }
     }