You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@calcite.apache.org by GitBox <gi...@apache.org> on 2019/08/06 07:57:24 UTC

[GitHub] [calcite] rubenada commented on a change in pull request #1247: [CALCITE-3089] Deprecate EquiJoin

rubenada commented on a change in pull request #1247: [CALCITE-3089] Deprecate EquiJoin
URL: https://github.com/apache/calcite/pull/1247#discussion_r310927086
 
 

 ##########
 File path: core/src/main/java/org/apache/calcite/adapter/enumerable/EnumerableHashJoin.java
 ##########
 @@ -56,8 +55,7 @@ protected EnumerableHashJoin(
       RelNode right,
       RexNode condition,
       Set<CorrelationId> variablesSet,
-      JoinRelType joinType)
-      throws InvalidRelException {
+      JoinRelType joinType) {
 
 Review comment:
   Would it make sense to add in this constructor a check on the condition (to verify that it is actually an equi-join, which is required by the underlying implementation algorithm)?
   ```
   if (!JoinInfo.of(left, right, condition).isEqui())
     throw new IllegalArgumentException("...");
   ```
   or maybe at least an assert
   `assert JoinInfo.of(left, right, condition).isEqui();`
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services