You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@accumulo.apache.org by GitBox <gi...@apache.org> on 2020/12/23 18:48:22 UTC
[GitHub] [accumulo] DomGarguilo opened a new pull request #1847: Fixes #1841 - Broken or Flaky test: ConcurrentDeleteTableIT takes 30 minutes to run
DomGarguilo opened a new pull request #1847:
URL: https://github.com/apache/accumulo/pull/1847
Added a timeout to both of the tests in this IT because they were observed taking far too long to complete as detailed in #1841. When I run these tests they both take about 40 seconds so I added a 3 minute timeout which should be plenty of time if they are running correctly. Not too sure why these tests took so long to complete, but these timeouts should ensure they are not running incorrectly for a long period of time.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo] DomGarguilo edited a comment on pull request #1847: Fixes #1841 - Broken or Flaky test: ConcurrentDeleteTableIT takes 30 minutes to run
Posted by GitBox <gi...@apache.org>.
DomGarguilo edited a comment on pull request #1847:
URL: https://github.com/apache/accumulo/pull/1847#issuecomment-751741392
For some reason I am now experiencing much longer run times for these tests. As noted earlier, they each ran in about 40 seconds. Now, with no changes, they are both running about 4-4.5 minutes each. Not sure why this is happening but I will add a longer timeout for now and then look deeper into what takes these tests so long.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo] ctubbsii commented on a change in pull request #1847: Fixes #1841 - Broken or Flaky test: ConcurrentDeleteTableIT takes 30 minutes to run
Posted by GitBox <gi...@apache.org>.
ctubbsii commented on a change in pull request #1847:
URL: https://github.com/apache/accumulo/pull/1847#discussion_r548140174
##########
File path: test/src/main/java/org/apache/accumulo/test/functional/ConcurrentDeleteTableIT.java
##########
@@ -52,7 +52,7 @@
public class ConcurrentDeleteTableIT extends AccumuloClusterHarness {
- @Test
+ @Test(timeout = 3 * 60 * 1000)
Review comment:
In the super class, we have a method that can be overridden called `defaultTimeoutSeconds`, which probably would work better for this. The timeout for that is scalable on the command-line with `-Dtimeout.factor=2` or similar. See `SplitIT.java` for an example.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo] ctubbsii commented on pull request #1847: Fixes #1841 - Broken or Flaky test: ConcurrentDeleteTableIT takes 30 minutes to run
Posted by GitBox <gi...@apache.org>.
ctubbsii commented on pull request #1847:
URL: https://github.com/apache/accumulo/pull/1847#issuecomment-754065589
> ... as long as it does not have any adverse implications if changed.
Right. That is what needs to be investigated.
For now, I can merge this timeout change.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo] DomGarguilo commented on pull request #1847: Fixes #1841 - Broken or Flaky test: ConcurrentDeleteTableIT takes 30 minutes to run
Posted by GitBox <gi...@apache.org>.
DomGarguilo commented on pull request #1847:
URL: https://github.com/apache/accumulo/pull/1847#issuecomment-751741392
For some reason I am now experiencing much longer run times for these tests. As noted earlier, they each ran in about 40 seconds. Now, with no changes, they are both running about 4.5 minutes each. Not sure why this is happening but I will add a longer timeout for now and then look deeper into what takes these tests so long.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo] ctubbsii commented on pull request #1847: Fixes #1841 - Broken or Flaky test: ConcurrentDeleteTableIT takes 30 minutes to run
Posted by GitBox <gi...@apache.org>.
ctubbsii commented on pull request #1847:
URL: https://github.com/apache/accumulo/pull/1847#issuecomment-754067663
Accidentally edited out the reference to this issue when updating the commit message during the merge. dd637c350b388e31aadad85f3616f6f0a1d07272 should reference this issue, #1847
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo] ctubbsii merged pull request #1847: Fixes #1841 - Broken or Flaky test: ConcurrentDeleteTableIT takes 30 minutes to run
Posted by GitBox <gi...@apache.org>.
ctubbsii merged pull request #1847:
URL: https://github.com/apache/accumulo/pull/1847
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo] DomGarguilo commented on pull request #1847: Fixes #1841 - Broken or Flaky test: ConcurrentDeleteTableIT takes 30 minutes to run
Posted by GitBox <gi...@apache.org>.
DomGarguilo commented on pull request #1847:
URL: https://github.com/apache/accumulo/pull/1847#issuecomment-754006618
I commented this on the issue page as well ([linked here](https://github.com/apache/accumulo/issues/1841#issuecomment-751815511)), but it seems that the number of splits in this test significantly impacts the duration of the tests. If we wanted these tests to be shorter, this might be a good change as long as it does not have any adverse implications if changed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org