You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@ignite.apache.org by "sanpwc (via GitHub)" <gi...@apache.org> on 2024/11/22 09:39:51 UTC

Re: [PR] IGNITE-23708 testAutomaticRebalanceIfMajorityIsLost is flaky [ignite-3]

sanpwc commented on code in PR #4747:
URL: https://github.com/apache/ignite-3/pull/4747#discussion_r1853627459


##########
modules/table/src/main/java/org/apache/ignite/internal/table/distributed/disaster/GroupUpdateRequest.java:
##########
@@ -304,14 +304,19 @@ private static CompletableFuture<Integer> partitionUpdate(
 
         Assignment nextAssignment = nextAssignment(localPartitionStateMessageByNode, partAssignments);
 
+        boolean isNextEqualsToRestoredAsPlannedAssignments = partAssignments.size() == 1 && partAssignments.contains(nextAssignment);

Review Comment:
   I believe that something like `isProposedPendingEqualsProposedPlanned` would be clearer. Up to you.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org