You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "Torben Giesselmann (JIRA)" <ji...@codehaus.org> on 2008/04/05 21:56:59 UTC

[jira] Issue Comment Edited: (MRELEASE-128) SCM properties being replaced during release:perform

    [ http://jira.codehaus.org/browse/MRELEASE-128?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=129909#action_129909 ] 

torbengee edited comment on MRELEASE-128 at 4/5/08 2:56 PM:
---------------------------------------------------------------------

Here's a patch which fixes the problems for pom.xml.next and pom.xml.tag:
[^MNG-128-maven-release-manager.patch]

Branching is not (yet) supported.

It works like this: instead of using {{scm.getConnection()}} and {{scm.getDeveloperConnection()}} (which both contain the resolved variables), it uses the original text contained in pom.xml (using the XML element).

HOWEVER ... the tests for {{RewritePomsForDevelopmentPhase}} fail. I don't know exactly what's going on, but ... hmm, could the tests be wrong? (This is a silly assumption, I know, but ... well, I just don't know.)

Still, after patching you can install {{maven-release-manager}} with

{{mvn -Dmaven.test.skip=true clean install}}

and see if it works for you, too.

      was (Author: torbengee):
    Here's a patch which fixes the problems for pom.xml.next and pom.xml.tag.
Branching is not (yet) supported.

It works like this: instead of using {{scm.getConnection()}} and {{scm.getDeveloperConnection()}} (which both contain the resolved variables), it uses the original text contained in pom.xml (using the XML element).

HOWEVER ... the tests for {{RewritePomsForDevelopmentPhase}} fail. I don't know exactly what's going on, but ... hmm, could the tests be wrong? (This is a silly assumption, I know, but ... well, I just don't know.)

Still, after patching you can install {{maven-release-manager}} with

{{mvn -Dmaven.test.skip=true clean install}}

and see if it works for you, too.
  
> SCM properties being replaced during release:perform
> ----------------------------------------------------
>
>                 Key: MRELEASE-128
>                 URL: http://jira.codehaus.org/browse/MRELEASE-128
>             Project: Maven 2.x Release Plugin
>          Issue Type: Bug
>         Environment: Windows XP client, Linux repo, CVS, Maven 2.0.4
>            Reporter: Craig Dickson
>            Assignee: Emmanuel Venisse
>            Priority: Critical
>             Fix For: 2.0
>
>         Attachments: after-release-perform-pom.xml, after-release-prepre-pom.xml, MNG-128-maven-release-manager.patch, MRELEASE-128_cvs_hack_RewritePomsForDevelopmentPhase.java.patch, original-pom.xml
>
>
> The <scm> section of a pom in CVS for a pom archetype project looks like this prior to executing release:prepare :
> <scm>
> 	<connection>${base.cvs.url}:commons-maven/uber-pom</connection>
> 	<developerConnection>${base.cvs.url}:commons-maven/uber-pom</developerConnection>
> 	<url>${base.viewcvs.url}/commons-maven/uber-pom</url>
> </scm>
> Then after executing release:prepare, the pom in CVS looks like this (new <tag> tag is only difference):
> <scm>
> 	<connection>${base.cvs.url}:commons-maven/uber-pom</connection>
> 	<developerConnection>${base.cvs.url}:commons-maven/uber-pom</developerConnection>
> 	<url>${base.viewcvs.url}/commons-maven/uber-pom</url>
> 	<tag>R-1_7</tag>
> </scm>
> Then after executing release:perform, the pom looks like this in CVS:
> <scm>
> 	<connection>scm:cvs:pserver:behrcvs.masco-coatings.com:/usr/cvsroot:commons-maven/uber-pom</connection>
> 	<developerConnection>scm:cvs:pserver:behrcvs.masco-coatings.com:/usr/cvsroot:commons-maven/uber-pom</developerConnection>
> 	<url>http://behrcvs.masco-coatings.com/cgi-bin/viewcvs.cgi/commons-maven/uber-pom</url>
> </scm>
> Notice that the properties that were there for the base URLs for CVS and ViewCVS have been replaced with literal values. 
> No other properties in the POM are being replaced

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira