You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "5 (via GitHub)" <gi...@apache.org> on 2023/06/29 15:38:34 UTC
[GitHub] [cassandra-analytics] 5 commented on a diff in pull request #9: [CASSANDRA-18633] Added Caching of Node Settings to Improve Efficiency
5 commented on code in PR #9:
URL: https://github.com/apache/cassandra-analytics/pull/9#discussion_r1246812708
##########
cassandra-analytics-core/src/main/java/org/apache/cassandra/spark/bulkwriter/CassandraClusterInfo.java:
##########
@@ -338,11 +339,23 @@ public String getVersionFromFeature()
public String getVersionFromSidecar()
{
- LOGGER.info("Getting Cassandra versions from all nodes");
- List<NodeSettings> allNodeSettings = Sidecar.allNodeSettingsBlocking(conf,
- cassandraContext.getSidecarClient(),
- cassandraContext.clusterConfig);
- return getLowestVersion(allNodeSettings);
+ List<NodeSettings> currentAllNodeSettings = allNodeSettings;
+ if (currentAllNodeSettings != null)
+ {
+ return getLowestVersion(currentAllNodeSettings);
+ }
+
+ synchronized (this)
+ {
+ if (allNodeSettings == null)
+ {
+ LOGGER.info("Getting Cassandra versions from all nodes");
+ allNodeSettings = Sidecar.allNodeSettingsBlocking(conf,
+ cassandraContext.getSidecarClient(),
+ cassandraContext.clusterConfig);
+ }
+ return getLowestVersion(allNodeSettings);
Review Comment:
Refactored.
(I was trying to keep style consistent with other methods within the same class.)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For additional commands, e-mail: commits-help@cassandra.apache.org