You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@myfaces.apache.org by "Mark Struberg (JIRA)" <de...@myfaces.apache.org> on 2012/05/10 20:36:49 UTC

[jira] [Created] (EXTCDI-284) ClientSideWindowHandler currently only checks for an empty window.name

Mark Struberg created EXTCDI-284:
------------------------------------

             Summary: ClientSideWindowHandler currently only checks for an empty window.name
                 Key: EXTCDI-284
                 URL: https://issues.apache.org/jira/browse/EXTCDI-284
             Project: MyFaces CODI
          Issue Type: Improvement
          Components: JEE-JSF20-Module
    Affects Versions: 1.0.5
            Reporter: Mark Struberg
            Assignee: Mark Struberg


we currently only check for an empty window.name for detecting a new tab. But this doesn't cover the case that someone opens a new tab with target or just uses a previously copied bookmark. 

All those cases can be perfectly handled by just comparing the window.name with the windowId from the URL. It if is the same then we are on the right tab. Otherwise we need to use the window.name (if not empty) or request a new windowId.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Resolved] (EXTCDI-284) ClientSideWindowHandler currently only checks for an empty window.name

Posted by "Mark Struberg (JIRA)" <de...@myfaces.apache.org>.
     [ https://issues.apache.org/jira/browse/EXTCDI-284?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Mark Struberg resolved EXTCDI-284.
----------------------------------

       Resolution: Fixed
    Fix Version/s: 1.0.6

we now always take the window.name as windowId (if a window.name is set).
                
> ClientSideWindowHandler currently only checks for an empty window.name
> ----------------------------------------------------------------------
>
>                 Key: EXTCDI-284
>                 URL: https://issues.apache.org/jira/browse/EXTCDI-284
>             Project: MyFaces CODI
>          Issue Type: Improvement
>          Components: JEE-JSF20-Module
>    Affects Versions: 1.0.5
>            Reporter: Mark Struberg
>            Assignee: Mark Struberg
>             Fix For: 1.0.6
>
>
> we currently only check for an empty window.name for detecting a new tab. But this doesn't cover the case that someone opens a new tab with target or just uses a previously copied bookmark. 
> All those cases can be perfectly handled by just comparing the window.name with the windowId from the URL. It if is the same then we are on the right tab. Otherwise we need to use the window.name (if not empty) or request a new windowId.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira