You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Fang Wang <fa...@citrix.com> on 2013/06/28 01:10:33 UTC

Review Request 12144: Create template from snapshot, failed due to the vmdk file failure.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12144/
-----------------------------------------------------------

Review request for cloudstack and edison su.


Bugs: CLOUDSTACK-2384


Repository: cloudstack-git


Description
-------

This is for master-6-17-stable. Fix the bug cloudstack-2384


Diffs
-----

  plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/manager/VmwareStorageManagerImpl.java 4ae0f30 

Diff: https://reviews.apache.org/r/12144/diff/


Testing
-------

Create snapshot;
Create template of the snapshot, now the vmdk file is correctly created in template directory.

[root@nfs2 209]# ls -lt
total 410724
-rw-r--r-- 1 root root 420134912 Jun 27 14:19 585fcc4b-a00b-4dc3-a03b-cab09c41cd15-disk0.vmdk
-rw-r--r-- 1 root root       239 Jun 27 14:19 d2d4d8f2-2916-4034-8053-3ed011d1be6e.ova.meta
-rw-r--r-- 1 root root       299 Jun 27 14:19 template.properties
-rw-r--r-- 1 root root      3839 Jun 27 14:19 585fcc4b-a00b-4dc3-a03b-cab09c41cd15.ovf


Thanks,

Fang Wang


Re: Review Request 12144: Create template from snapshot, failed due to the vmdk file failure.

Posted by edison su <ed...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12144/#review22492
-----------------------------------------------------------

Ship it!


Ship It!

- edison su


On June 27, 2013, 11:10 p.m., Fang Wang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12144/
> -----------------------------------------------------------
> 
> (Updated June 27, 2013, 11:10 p.m.)
> 
> 
> Review request for cloudstack and edison su.
> 
> 
> Bugs: CLOUDSTACK-2384
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> This is for master-6-17-stable. Fix the bug cloudstack-2384
> 
> 
> Diffs
> -----
> 
>   plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/manager/VmwareStorageManagerImpl.java 4ae0f30 
> 
> Diff: https://reviews.apache.org/r/12144/diff/
> 
> 
> Testing
> -------
> 
> Create snapshot;
> Create template of the snapshot, now the vmdk file is correctly created in template directory.
> 
> [root@nfs2 209]# ls -lt
> total 410724
> -rw-r--r-- 1 root root 420134912 Jun 27 14:19 585fcc4b-a00b-4dc3-a03b-cab09c41cd15-disk0.vmdk
> -rw-r--r-- 1 root root       239 Jun 27 14:19 d2d4d8f2-2916-4034-8053-3ed011d1be6e.ova.meta
> -rw-r--r-- 1 root root       299 Jun 27 14:19 template.properties
> -rw-r--r-- 1 root root      3839 Jun 27 14:19 585fcc4b-a00b-4dc3-a03b-cab09c41cd15.ovf
> 
> 
> Thanks,
> 
> Fang Wang
> 
>


RE: Review Request 12144: Create template from snapshot, failed due to the vmdk file failure.

Posted by Edison Su <Ed...@citrix.com>.
The bug seems introduced in 13691048fb622467271b75fc7b64298e3afe9912, which is committed at March 16. So 4.1 should have the same issue.

> -----Original Message-----
> From: Musayev, Ilya [mailto:imusayev@webmd.net]
> Sent: Thursday, June 27, 2013 4:13 PM
> To: dev@cloudstack.apache.org; Fang Wang; Edison Su
> Cc: cloudstack
> Subject: RE: Review Request 12144: Create template from snapshot, failed
> due to the vmdk file failure.
> 
> Is this applicable to 4.1?
> 
> > -----Original Message-----
> > From: Fang Wang [mailto:noreply@reviews.apache.org] On Behalf Of Fang
> > Wang
> > Sent: Thursday, June 27, 2013 7:11 PM
> > To: edison su
> > Cc: cloudstack; Fang Wang
> > Subject: Review Request 12144: Create template from snapshot, failed
> > due to the vmdk file failure.
> >
> >
> > -----------------------------------------------------------
> > This is an automatically generated e-mail. To reply, visit:
> > https://reviews.apache.org/r/12144/
> > -----------------------------------------------------------
> >
> > Review request for cloudstack and edison su.
> >
> >
> > Bugs: CLOUDSTACK-2384
> >
> >
> > Repository: cloudstack-git
> >
> >
> > Description
> > -------
> >
> > This is for master-6-17-stable. Fix the bug cloudstack-2384
> >
> >
> > Diffs
> > -----
> >
> >
> >
> plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/manager/
> > VmwareStorageManagerImpl.java 4ae0f30
> >
> > Diff: https://reviews.apache.org/r/12144/diff/
> >
> >
> > Testing
> > -------
> >
> > Create snapshot;
> > Create template of the snapshot, now the vmdk file is correctly
> > created in template directory.
> >
> > [root@nfs2 209]# ls -lt
> > total 410724
> > -rw-r--r-- 1 root root 420134912 Jun 27 14:19 585fcc4b-a00b-4dc3-a03b-
> > cab09c41cd15-disk0.vmdk
> > -rw-r--r-- 1 root root       239 Jun 27 14:19 d2d4d8f2-2916-4034-8053-
> > 3ed011d1be6e.ova.meta
> > -rw-r--r-- 1 root root       299 Jun 27 14:19 template.properties
> > -rw-r--r-- 1 root root      3839 Jun 27 14:19 585fcc4b-a00b-4dc3-a03b-
> > cab09c41cd15.ovf
> >
> >
> > Thanks,
> >
> > Fang Wang


RE: Review Request 12144: Create template from snapshot, failed due to the vmdk file failure.

Posted by "Musayev, Ilya" <im...@webmd.net>.
Is this applicable to 4.1?

> -----Original Message-----
> From: Fang Wang [mailto:noreply@reviews.apache.org] On Behalf Of Fang
> Wang
> Sent: Thursday, June 27, 2013 7:11 PM
> To: edison su
> Cc: cloudstack; Fang Wang
> Subject: Review Request 12144: Create template from snapshot, failed due
> to the vmdk file failure.
> 
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12144/
> -----------------------------------------------------------
> 
> Review request for cloudstack and edison su.
> 
> 
> Bugs: CLOUDSTACK-2384
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> This is for master-6-17-stable. Fix the bug cloudstack-2384
> 
> 
> Diffs
> -----
> 
> 
> plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/manager/
> VmwareStorageManagerImpl.java 4ae0f30
> 
> Diff: https://reviews.apache.org/r/12144/diff/
> 
> 
> Testing
> -------
> 
> Create snapshot;
> Create template of the snapshot, now the vmdk file is correctly created in
> template directory.
> 
> [root@nfs2 209]# ls -lt
> total 410724
> -rw-r--r-- 1 root root 420134912 Jun 27 14:19 585fcc4b-a00b-4dc3-a03b-
> cab09c41cd15-disk0.vmdk
> -rw-r--r-- 1 root root       239 Jun 27 14:19 d2d4d8f2-2916-4034-8053-
> 3ed011d1be6e.ova.meta
> -rw-r--r-- 1 root root       299 Jun 27 14:19 template.properties
> -rw-r--r-- 1 root root      3839 Jun 27 14:19 585fcc4b-a00b-4dc3-a03b-
> cab09c41cd15.ovf
> 
> 
> Thanks,
> 
> Fang Wang