[jira] [Commented] (HADOOP-10560) Update NativeS3FileSystem to issue copy commands for files with in a directory with a configurable number of threads

["Steve Loughran (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HADOOP-10560?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14532301#comment-14532301 ] 

Steve Loughran commented on HADOOP-10560:
-----------------------------------------

given this is just being up for review, can I state that I'm -1 to this, and pretty much any other change to s3n. I'm the one that ends up fielding late-night emergency patches to s3n; all the changes last year (including fixes for regressions) have tended to introduce new problems. Better to leave alone and focus all dev on s3a

> Update NativeS3FileSystem to issue copy commands for files with in a directory with a configurable number of threads
> --------------------------------------------------------------------------------------------------------------------
>
>                 Key: HADOOP-10560
>                 URL: https://issues.apache.org/jira/browse/HADOOP-10560
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: fs/s3
>            Reporter: Ted Malaska
>            Assignee: Ted Malaska
>            Priority: Minor
>              Labels: BB2015-05-TBR, performance
>         Attachments: HADOOP-10560-1.patch, HADOOP-10560.patch
>
>
> In NativeS3FileSystem if you do a copy of a directory it will copy all the files to the new location, but it will do this with one thread. Code is below. This jira will allow a configurable number of threads to be used to issue the copy commands to S3.
> do {
> PartialListing listing = store.list(srcKey, S3_MAX_LISTING_LENGTH, priorLastKey, true);
> for (FileMetadata file : listing.getFiles())
> { keysToDelete.add(file.getKey()); store.copy(file.getKey(), dstKey + file.getKey().substring(srcKey.length())); }
> priorLastKey = listing.getPriorLastKey();
> } while (priorLastKey != null);



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)