You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@mesos.apache.org by "Benjamin Hindman (JIRA)" <ji...@apache.org> on 2014/11/21 02:45:33 UTC
[jira] [Resolved] (MESOS-2071) Libprocess generates invalid HTTP
[ https://issues.apache.org/jira/browse/MESOS-2071?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Benjamin Hindman resolved MESOS-2071.
-------------------------------------
Resolution: Fixed
Fix Version/s: 0.22.0
Assignee: Dario Rexin
commit 993dc2dc5389847a4da838a842bdbeff34031389
Author: Dario Rexin <da...@mesosphere.io>
Date: Thu Nov 20 17:41:08 2014 -0800
Made libprocess generate valid HTTP.
While working on a pure Scala driver for Mesos, I discovered that
libprocess does not generate valid HTTP. It uses chunked encoding
combined with HTTP 1.0, which has only been added in HTTP
1.1. Additionally it stores the PID in the User-Agent field with an
incompatibe format ('@' and ':' are not allowed). This patch sets the
HTTP version to 1.1, adds an empty Host header (Host is mandatory in
1.1) and adds the Libprocess-From header. The User-Agent header is
left untouched for backwards compatibility reasons. Even strict HTTP
parser shouldn't error, but just ignore everything between the invalid
character and the CRLF.
Review: https://reviews.apache.org/r/27865
> Libprocess generates invalid HTTP
> ---------------------------------
>
> Key: MESOS-2071
> URL: https://issues.apache.org/jira/browse/MESOS-2071
> Project: Mesos
> Issue Type: Bug
> Components: libprocess
> Affects Versions: 0.18.1, 0.19.1, 0.20.1
> Reporter: Dario Rexin
> Assignee: Dario Rexin
> Priority: Minor
> Labels: newbie, patch
> Fix For: 0.22.0
>
>
> While working on a pure Scala driver for Mesos, I discovered that libprocess does not generate valid HTTP. It uses chunked encoding combined with HTTP 1.0, which has only been added in HTTP 1.1. Additionally it stores the PID in the User-Agent field with an incompatible format ('@' and ':' are not allowed).
> I already uploaded a patch to reviewboard: https://reviews.apache.org/r/27865/
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)