You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by pengcheng xiong <px...@hortonworks.com> on 2014/10/08 01:05:07 UTC

Review Request 26427: Disable CBO when indexes are used

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26427/
-----------------------------------------------------------

Review request for hive and Gunther Hagleitner.


Repository: hive-git


Description
-------

Disable CBO when indexes are used, related to https://issues.apache.org/jira/browse/HIVE-8389


Diffs
-----

  ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java 19110ce 

Diff: https://reviews.apache.org/r/26427/diff/


Testing
-------


Thanks,

pengcheng xiong


Re: Review Request 26427: Disable CBO when indexes are used

Posted by pengcheng xiong <px...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26427/
-----------------------------------------------------------

(Updated Oct. 14, 2014, 4:12 a.m.)


Review request for hive and Gunther Hagleitner.


Repository: hive-git


Description
-------

Disable CBO when indexes are used


Diffs
-----

  common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 6a1a5f0 
  ql/src/java/org/apache/hadoop/hive/ql/index/IndexPredicateAnalyzer.java 683618f 
  ql/src/java/org/apache/hadoop/hive/ql/optimizer/Optimizer.java bc4ad2f 
  ql/src/test/queries/clientnegative/set_hiveconf_validation2.q 579e940 
  ql/src/test/queries/clientpositive/index_auto_partitioned.q 49df8f2 
  ql/src/test/queries/clientpositive/index_bitmap_auto_partitioned.q 011d77a 
  ql/src/test/results/clientnegative/set_hiveconf_validation2.q.out 33f9360 

Diff: https://reviews.apache.org/r/26427/diff/


Testing
-------


Thanks,

pengcheng xiong


Re: Review Request 26427: Disable CBO when indexes are used

Posted by pengcheng xiong <px...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26427/
-----------------------------------------------------------

(Updated Oct. 14, 2014, 4:12 a.m.)


Review request for hive and Gunther Hagleitner.


Changes
-------

address set_hiveconf_validation2


Repository: hive-git


Description
-------

Disable CBO when indexes are used


Diffs (updated)
-----

  common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 6a1a5f0 
  ql/src/java/org/apache/hadoop/hive/ql/index/IndexPredicateAnalyzer.java 683618f 
  ql/src/java/org/apache/hadoop/hive/ql/optimizer/Optimizer.java bc4ad2f 
  ql/src/test/queries/clientnegative/set_hiveconf_validation2.q 579e940 
  ql/src/test/queries/clientpositive/index_auto_partitioned.q 49df8f2 
  ql/src/test/queries/clientpositive/index_bitmap_auto_partitioned.q 011d77a 
  ql/src/test/results/clientnegative/set_hiveconf_validation2.q.out 33f9360 

Diff: https://reviews.apache.org/r/26427/diff/


Testing
-------


Thanks,

pengcheng xiong


Re: Review Request 26427: Disable CBO when indexes are used

Posted by pengcheng xiong <px...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26427/
-----------------------------------------------------------

(Updated Oct. 13, 2014, 7:33 p.m.)


Review request for hive and Gunther Hagleitner.


Changes
-------

In this patch,
(1) index is enabled for the following test cases in CliDriver: alter_concatenate_indexed_table.q,alter_index.q,authorization_index.q,drop_index_removes_partition_dirs.q,index_auth.q,index_auto.q,index_auto_empty.q,index_auto_file_format.q,index_auto_mult_tables.q,index_auto_mult_tables_compact.q,index_auto_multiple.q,index_auto_multipleX.q,index_auto_partitioned.q,index_auto_self_join.q,index_auto_unused.q,index_auto_update.q,index_bitmap.q,index_bitmap1.q,index_bitmap2.q,index_bitmap3.q,index_bitmap_auto.q,index_bitmap_auto_partitioned.q,index_bitmap_compression.q,index_bitmap_rc.q,index_compact.q,index_compact_1.q,index_compact_2.q,index_compact_3.q,index_compact_binary_search.q,index_compression.q,index_creation.q,index_serde.q,index_stale.q,index_stale_partitioned.q,show_indexes_edge_cases.q,show_indexes_syntax.q,udf_index.q
(2) the "fetch.task.conversion" optimization is disabled for index_auto_partitioned.q and index_bitmap_auto_partitioned.q because it will block index optimizer.
(3) And, index is enabled for ql_rewrite_gbtoidx.q in TestMinimrCliDriver


Repository: hive-git


Description
-------

Disable CBO when indexes are used


Diffs (updated)
-----

  common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 51fc68f 
  ql/src/java/org/apache/hadoop/hive/ql/index/IndexPredicateAnalyzer.java 683618f 
  ql/src/java/org/apache/hadoop/hive/ql/optimizer/Optimizer.java bc4ad2f 
  ql/src/test/queries/clientpositive/index_auto_partitioned.q 49df8f2 
  ql/src/test/queries/clientpositive/index_bitmap_auto_partitioned.q 011d77a 

Diff: https://reviews.apache.org/r/26427/diff/


Testing
-------


Thanks,

pengcheng xiong


Re: Review Request 26427: Disable CBO when indexes are used

Posted by pengcheng xiong <px...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26427/
-----------------------------------------------------------

(Updated Oct. 13, 2014, 7:31 p.m.)


Review request for hive and Gunther Hagleitner.


Repository: hive-git


Description (updated)
-------

Disable CBO when indexes are used


Diffs
-----

  ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java 19110ce 

Diff: https://reviews.apache.org/r/26427/diff/


Testing
-------


Thanks,

pengcheng xiong


Re: Review Request 26427: Disable CBO when indexes are used

Posted by pengcheng xiong <px...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26427/
-----------------------------------------------------------

(Updated Oct. 7, 2014, 11:05 p.m.)


Review request for hive and Gunther Hagleitner.


Repository: hive-git


Description
-------

Disable CBO when indexes are used, related to https://issues.apache.org/jira/browse/HIVE-8389


Diffs (updated)
-----

  ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java 19110ce 

Diff: https://reviews.apache.org/r/26427/diff/


Testing
-------


Thanks,

pengcheng xiong