You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by Greg Stein <gs...@lyra.org> on 2003/01/07 20:41:17 UTC

Re: svn commit: rev 4283 - trunk

On Tue, Jan 07, 2003 at 12:29:52PM -0600, brane@tigris.org wrote:
> Author: brane
> Date: 2003-01-07 12:29:37 -0600 (Tue, 07 Jan 2003)
> New Revision: 4283
> 
> Modified:
>    trunk/INSTALL
> Log:
> * INSTALL: Add a note about needin libtool 1.4.3 on Solaris.

Euh... why don't we just change buildcheck.sh? Developers who download onto
Solaris and run autogen.sh will get trapped up properly, and people who roll
tarballs will use the correct version.

That would be much nicer then a big-ass warning in the INSTALL document.

Cheers,
-g

-- 
Greg Stein, http://www.lyra.org/

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org

Re: svn commit: rev 4283 - trunk

Posted by Branko Čibej <br...@xbc.nu>.
Justin Erenkrantz wrote:

> --On Tuesday, January 7, 2003 4:58 PM -0800 Greg Stein
> <gs...@lyra.org> wrote:
>
>> Hmm. Is the 1.4.3 requirement onerous for the developers? If that
>> is the case, then maybe we can change the 'dist.sh' script. We
>> could make it so that just the person rolling the release needs
>> 1.4.3. Either encode that into dist.sh or pass a parameter to
>> autogen.sh (say, --release) which can then be passed to
>> buildcheck.sh to make it perform a more strict check.
>
>
> +1 to the --release option or something to do with dist.sh, but please
> don't make 1.4.3 a requirement for everyone.  -- justin
>
Done. I mean, not done. Well, really done, but not completely. Oh,
bother... :-)
See 4285.

-- 
Brane Čibej   <br...@xbc.nu>   http://www.xbc.nu/brane/


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org

Re: svn commit: rev 4283 - trunk

Posted by Justin Erenkrantz <je...@apache.org>.
--On Tuesday, January 7, 2003 4:58 PM -0800 Greg Stein 
<gs...@lyra.org> wrote:

> Hmm. Is the 1.4.3 requirement onerous for the developers? If that
> is the case, then maybe we can change the 'dist.sh' script. We
> could make it so that just the person rolling the release needs
> 1.4.3. Either encode that into dist.sh or pass a parameter to
> autogen.sh (say, --release) which can then be passed to
> buildcheck.sh to make it perform a more strict check.

+1 to the --release option or something to do with dist.sh, but 
please don't make 1.4.3 a requirement for everyone.  -- justin

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org

Re: svn commit: rev 4283 - trunk

Posted by Branko Čibej <br...@xbc.nu>.
Greg Stein wrote:

>On Wed, Jan 08, 2003 at 01:44:53AM +0100, Branko Cibej wrote:
>  
>
>>Greg Stein wrote:
>>    
>>
>>>On Tue, Jan 07, 2003 at 12:29:52PM -0600, brane@tigris.org wrote:
>>>      
>>>
>>...
>>    
>>
>>>>* INSTALL: Add a note about needin libtool 1.4.3 on Solaris.
>>>>        
>>>>
>>>Euh... why don't we just change buildcheck.sh? Developers who download onto
>>>Solaris and run autogen.sh will get trapped up properly, and people who roll
>>>tarballs will use the correct version.
>>>      
>>>
>>...
>>Do you mean to require 1.4.3 everywhere, or just on Solaris? I have the
>>second solution done in build/buildcheck.sh, _but_ it means that
>>tarballs have to be created with libtool 1.4.3, so that Solaris people
>>can use them to build Subversion. I'd rather not make 1.4.3 a
>>requirement everywhere, though.
>>    
>>
>
>Everywhere, yes, for the tarball situation.
>
>I believe that MacOS X also needs libtool 1.4.3.
>
>Hmm. Is the 1.4.3 requirement onerous for the developers? If that is the
>case, then maybe we can change the 'dist.sh' script. We could make it so
>that just the person rolling the release needs 1.4.3. Either encode that
>into dist.sh or pass a parameter to autogen.sh (say, --release) which can
>then be passed to buildcheck.sh to make it perform a more strict check.
>  
>

I'll go with the second solution. I'm committing the buildchecck.sh
change that requires 1.4.3 only on Solaris (some MacOS X person can add
that requirement later, if necessary). I'll add the --release flag and
appropriate magic in a later commit. It seems wrong to require 1.4.3,
say, on Linux just because Solaris needs it.

-- 
Brane Čibej   <br...@xbc.nu>   http://www.xbc.nu/brane/


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org

Re: svn commit: rev 4283 - trunk

Posted by Greg Stein <gs...@lyra.org>.
On Wed, Jan 08, 2003 at 01:44:53AM +0100, Branko Cibej wrote:
> Greg Stein wrote:
> >On Tue, Jan 07, 2003 at 12:29:52PM -0600, brane@tigris.org wrote:
>...
> >>* INSTALL: Add a note about needin libtool 1.4.3 on Solaris.
> >
> >Euh... why don't we just change buildcheck.sh? Developers who download onto
> >Solaris and run autogen.sh will get trapped up properly, and people who roll
> >tarballs will use the correct version.
>...
> Do you mean to require 1.4.3 everywhere, or just on Solaris? I have the
> second solution done in build/buildcheck.sh, _but_ it means that
> tarballs have to be created with libtool 1.4.3, so that Solaris people
> can use them to build Subversion. I'd rather not make 1.4.3 a
> requirement everywhere, though.

Everywhere, yes, for the tarball situation.

I believe that MacOS X also needs libtool 1.4.3.

Hmm. Is the 1.4.3 requirement onerous for the developers? If that is the
case, then maybe we can change the 'dist.sh' script. We could make it so
that just the person rolling the release needs 1.4.3. Either encode that
into dist.sh or pass a parameter to autogen.sh (say, --release) which can
then be passed to buildcheck.sh to make it perform a more strict check.

Cheers,
-g

-- 
Greg Stein, http://www.lyra.org/

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org

Re: svn commit: rev 4283 - trunk

Posted by Branko Čibej <br...@xbc.nu>.
Greg Stein wrote:

>On Tue, Jan 07, 2003 at 12:29:52PM -0600, brane@tigris.org wrote:
>  
>
>>Author: brane
>>Date: 2003-01-07 12:29:37 -0600 (Tue, 07 Jan 2003)
>>New Revision: 4283
>>
>>Modified:
>>   trunk/INSTALL
>>Log:
>>* INSTALL: Add a note about needin libtool 1.4.3 on Solaris.
>>    
>>
>
>Euh... why don't we just change buildcheck.sh? Developers who download onto
>Solaris and run autogen.sh will get trapped up properly, and people who roll
>tarballs will use the correct version.
>
>That would be much nicer then a big-ass warning in the INSTALL document.
>
>Cheers,
>-g
>  
>

Do you mean to require 1.4.3 everywhere, or just on Solaris? I have the
second solution done in build/buildcheck.sh, _but_ it means that
tarballs have to be created with libtool 1.4.3, so that Solaris people
can use them to build Subversion. I'd rather not make 1.4.3 a
requirement everywhere, though.

-- 
Brane Čibej   <br...@xbc.nu>   http://www.xbc.nu/brane/


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org