You are viewing a plain text version of this content. The canonical link for it is here.
Posted to java-dev@axis.apache.org by "Christian Ribeaud (JIRA)" <ji...@apache.org> on 2007/06/01 14:23:15 UTC
[jira] Created: (AXIS2-2754) No possibility to trace back the cause
of AxisFault thrown in org.apache.axis2.rpc.receivers.RPCMessageReceiver
No possibility to trace back the cause of AxisFault thrown in org.apache.axis2.rpc.receivers.RPCMessageReceiver
---------------------------------------------------------------------------------------------------------------
Key: AXIS2-2754
URL: https://issues.apache.org/jira/browse/AXIS2-2754
Project: Axis 2.0 (Axis2)
Issue Type: Bug
Components: adb
Affects Versions: 1.2
Environment: Not important.
Reporter: Christian Ribeaud
In the InvocationTargetException catch block (starting at line l. 138), we can see the following:
(l. 152) throw new AxisFault(msg);
forgetting to put the culprit. I think this is wrong. So there is no possibility on the client side
to know which exception caused the problem. Better would be:
throw new AxisFault(msg, cause);
A yet better way would be to erase this block and to put the following in the Exception catch block:
throw AxisFault.makeFault(e);
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: axis-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: axis-dev-help@ws.apache.org
[jira] Commented: (AXIS2-2754) No possibility to trace back the
cause of AxisFault thrown in
org.apache.axis2.rpc.receivers.RPCMessageReceiver
Posted by "Davanum Srinivas (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/AXIS2-2754?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12502028 ]
Davanum Srinivas commented on AXIS2-2754:
-----------------------------------------
Fixed in svn revision 544917. i opted for adding the exception instead of calling makeFault.
thanks,
dims
> No possibility to trace back the cause of AxisFault thrown in org.apache.axis2.rpc.receivers.RPCMessageReceiver
> ---------------------------------------------------------------------------------------------------------------
>
> Key: AXIS2-2754
> URL: https://issues.apache.org/jira/browse/AXIS2-2754
> Project: Axis 2.0 (Axis2)
> Issue Type: Bug
> Components: adb
> Affects Versions: 1.2
> Environment: Not important.
> Reporter: Christian Ribeaud
> Attachments: RPCMessageReceiver.java
>
>
> In the InvocationTargetException catch block (starting at line l. 138), we can see the following:
> (l. 152) throw new AxisFault(msg);
> forgetting to put the culprit. I think this is wrong. So there is no possibility on the client side
> to know which exception caused the problem. Better would be:
> throw new AxisFault(msg, cause);
> A yet better way would be to erase this block and to put the following in the Exception catch block:
> throw AxisFault.makeFault(e);
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: axis-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: axis-dev-help@ws.apache.org
[jira] Resolved: (AXIS2-2754) No possibility to trace back the
cause of AxisFault thrown in
org.apache.axis2.rpc.receivers.RPCMessageReceiver
Posted by "Davanum Srinivas (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/AXIS2-2754?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Davanum Srinivas resolved AXIS2-2754.
-------------------------------------
Resolution: Fixed
> No possibility to trace back the cause of AxisFault thrown in org.apache.axis2.rpc.receivers.RPCMessageReceiver
> ---------------------------------------------------------------------------------------------------------------
>
> Key: AXIS2-2754
> URL: https://issues.apache.org/jira/browse/AXIS2-2754
> Project: Axis 2.0 (Axis2)
> Issue Type: Bug
> Components: adb
> Affects Versions: 1.2
> Environment: Not important.
> Reporter: Christian Ribeaud
> Attachments: RPCMessageReceiver.java
>
>
> In the InvocationTargetException catch block (starting at line l. 138), we can see the following:
> (l. 152) throw new AxisFault(msg);
> forgetting to put the culprit. I think this is wrong. So there is no possibility on the client side
> to know which exception caused the problem. Better would be:
> throw new AxisFault(msg, cause);
> A yet better way would be to erase this block and to put the following in the Exception catch block:
> throw AxisFault.makeFault(e);
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: axis-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: axis-dev-help@ws.apache.org
[jira] Issue Comment Edited: (AXIS2-2754) No possibility to trace
back the cause of AxisFault thrown in
org.apache.axis2.rpc.receivers.RPCMessageReceiver
Posted by "Christian Ribeaud (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/AXIS2-2754?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12500692 ]
Christian Ribeaud edited comment on AXIS2-2754 at 6/1/07 5:42 AM:
------------------------------------------------------------------
This would be my version of the whole class. Exception handling is very similar to the one used in RawXMLINOutMessageReceiver (see attachment).
By the way, we have the same problem in RPCInOnlyMessageReceiver and the same fix should be applied.
was:
This would be my version of the whole class. Exception handling is very similar to the one used in RawXMLINOutMessageReceiver.
> No possibility to trace back the cause of AxisFault thrown in org.apache.axis2.rpc.receivers.RPCMessageReceiver
> ---------------------------------------------------------------------------------------------------------------
>
> Key: AXIS2-2754
> URL: https://issues.apache.org/jira/browse/AXIS2-2754
> Project: Axis 2.0 (Axis2)
> Issue Type: Bug
> Components: adb
> Affects Versions: 1.2
> Environment: Not important.
> Reporter: Christian Ribeaud
> Attachments: RPCMessageReceiver.java
>
>
> In the InvocationTargetException catch block (starting at line l. 138), we can see the following:
> (l. 152) throw new AxisFault(msg);
> forgetting to put the culprit. I think this is wrong. So there is no possibility on the client side
> to know which exception caused the problem. Better would be:
> throw new AxisFault(msg, cause);
> A yet better way would be to erase this block and to put the following in the Exception catch block:
> throw AxisFault.makeFault(e);
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: axis-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: axis-dev-help@ws.apache.org
[jira] Updated: (AXIS2-2754) No possibility to trace back the cause
of AxisFault thrown in org.apache.axis2.rpc.receivers.RPCMessageReceiver
Posted by "Christian Ribeaud (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/AXIS2-2754?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Christian Ribeaud updated AXIS2-2754:
-------------------------------------
Attachment: RPCMessageReceiver.java
This would be my version of the whole class. Exception handling is very similar to the one used in RawXMLINOutMessageReceiver.
> No possibility to trace back the cause of AxisFault thrown in org.apache.axis2.rpc.receivers.RPCMessageReceiver
> ---------------------------------------------------------------------------------------------------------------
>
> Key: AXIS2-2754
> URL: https://issues.apache.org/jira/browse/AXIS2-2754
> Project: Axis 2.0 (Axis2)
> Issue Type: Bug
> Components: adb
> Affects Versions: 1.2
> Environment: Not important.
> Reporter: Christian Ribeaud
> Attachments: RPCMessageReceiver.java
>
>
> In the InvocationTargetException catch block (starting at line l. 138), we can see the following:
> (l. 152) throw new AxisFault(msg);
> forgetting to put the culprit. I think this is wrong. So there is no possibility on the client side
> to know which exception caused the problem. Better would be:
> throw new AxisFault(msg, cause);
> A yet better way would be to erase this block and to put the following in the Exception catch block:
> throw AxisFault.makeFault(e);
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: axis-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: axis-dev-help@ws.apache.org