You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/10/20 08:01:07 UTC

[GitHub] [arrow-datafusion] Ted-Jiang commented on a diff in pull request #3903: Factorize common AND factors out of OR predicates to support filterPu…

Ted-Jiang commented on code in PR #3903:
URL: https://github.com/apache/arrow-datafusion/pull/3903#discussion_r1000275988


##########
datafusion/optimizer/src/filter_push_down.rs:
##########
@@ -797,7 +817,7 @@ impl OptimizerRule for FilterPushDown {
         plan: &LogicalPlan,
         _: &mut OptimizerConfig,
     ) -> Result<LogicalPlan> {
-        optimize(plan, State::default())
+        optimize(plan, State::default().with_cnf_rewrite())

Review Comment:
   @alamb   test fail cause of after https://github.com/apache/arrow-datafusion/pull/3880, it runs rules multiple times.
   When after running first time it will produce `filter` front (near `scan`) the `join`, but we don't need write the filter-expr after pushDown (expect page index, i will manually add it), so i add this option.🤔



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org