[GitHub] [incubator-mxnet] zoeygxy commented on a change in pull request #15814: Numpy LCM (lowest common multiple) operator

[GitBox <gi...@apache.org>]

zoeygxy commented on a change in pull request #15814: Numpy LCM (lowest common multiple) operator
URL: https://github.com/apache/incubator-mxnet/pull/15814#discussion_r317464556
 
 

 ##########
 File path: src/operator/numpy/np_elemwise_broadcast_op.cc
 ##########
 @@ -39,6 +39,33 @@ bool NumpyBinaryScalarType(const nnvm::NodeAttrs& attrs,
   return in_attrs->at(0) != -1;
 }
 
+bool NumpyBinaryScalarIntType(const nnvm::NodeAttrs& attrs,
+                              std::vector<int>* in_attrs,
+                              std::vector<int>* out_attrs) {
+  CHECK(in_attrs->at(0) == mshadow::kInt64 ||
+        in_attrs->at(0) == mshadow::kInt32 ||
+        in_attrs->at(0) == mshadow::kInt8 ||
+        in_attrs->at(0) == mshadow::kUint8) << "Only support integral type.";
 
 Review comment:
   "Only supports **integer** type."

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services