You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@rocketmq.apache.org by "Loyal-Young (via GitHub)" <gi...@apache.org> on 2026/10/02 10:44:30 UTC

[PR] fix(proxy): invalidate pending loads on page unmount [rocketmq-dashboard]

Loyal-Young opened a new pull request, #5366:
URL: https://github.com/apache/rocketmq-dashboard/pull/5366

   ### Which Issue(s) This PR Fixes
   
   - Fixes #5364
   
   ### Brief Description
   
   The Proxy page captured the request generation before starting its initial load, then restored `captured + 1` on cleanup. That equals the in-flight request's generation, so a response arriving after unmount could still run `applyProxyHome()` and persist a Proxy address. Cleanup now increments the *current* generation, invalidating whichever request is active when the page leaves.
   
   This is separate from the failed health-probe race covered by open PR #5256.
   
   ### Verification
   
   - New regression test failed before the fix: `getProxyTopology` was called after unmount, proving the old response entered `applyProxyHome()`.
   - `cd web && node node_modules/vitest/vitest.mjs run src/pages/studio/__tests__/Proxy.test.tsx --pool=threads --maxWorkers=1 --reporter=dot` — 16 tests passed after the fix.
   - `cd web && node node_modules/eslint/bin/eslint.js src/pages/studio/Proxy.tsx src/pages/studio/__tests__/Proxy.test.tsx` — passed.
   - `cd web && node node_modules/typescript/bin/tsc -p tsconfig.app.json --noEmit --pretty false` — passed.
   - `git diff --check` — passed.
   
   ### AI Assistance
   
   AI assistance helped inspect the request-generation lifecycle and draft the unmount regression. I confirmed the test failed on the unmodified code, reviewed the one-line invalidation change, and ran the checks above.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] fix(proxy): invalidate pending loads on page unmount [rocketmq-dashboard]

Posted by "lizhimins (via GitHub)" <gi...@apache.org>.
lizhimins closed pull request #5366: fix(proxy): invalidate pending loads on page unmount
URL: https://github.com/apache/rocketmq-dashboard/pull/5366


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] fix(proxy): invalidate pending loads on page unmount [rocketmq-dashboard]

Posted by "lizhimins (via GitHub)" <gi...@apache.org>.
lizhimins commented on PR #5366:
URL: https://github.com/apache/rocketmq-dashboard/pull/5366#issuecomment-6093570402

   Merged as part of #5362 (squashed into `rocketmq-studio` as c4135abe7).
   
   We are consolidating same-author changes into one commit rather than landing several near-identical ones on the trunk; your commit stays visible on this pull request and is credited in the merge body. Closing - no action needed, and thanks for the fix.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] fix(proxy): invalidate pending loads on page unmount [rocketmq-dashboard]

Posted by "Loyal-Young (via GitHub)" <gi...@apache.org>.
Loyal-Young commented on PR #5366:
URL: https://github.com/apache/rocketmq-dashboard/pull/5366#issuecomment-6076133548

   ### Maintenance update — 2026-10-09
   
   I am still maintaining this PR and awaiting review. The change invalidates the current Proxy-page request generation on unmount so a late response cannot apply the proxy address.
   
   Local validation recorded on October 2: 16 Proxy tests passed, including the regression that failed before the fix. ESLint, TypeScript and diff checks passed. The commands and reproduction details are in the PR description.
   
   The current [CI run](https://github.com/apache/rocketmq-dashboard/actions/runs/36997138566) has rmqctl Build passing and the three build jobs failing. The Backend Tests log also reports `ResourceOwnershipGuardTest.migrationConcurrentStartupIsIdempotentTest` failing with an H2 `ConcurrentModificationException` (3,322 tests, one error).
   
   Please keep this PR open for review. If the review queue exceeds the seven-day inactivity window, a maintainer-applied `pinned` label would help, as described in the contribution guide. I am available to address review feedback.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org