You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@royale.apache.org by gr...@apache.org on 2020/06/09 21:53:50 UTC
[royale-asjs] branch develop updated: Fix an XML regression in
XML.elements query. Added test coverage for this.
This is an automated email from the ASF dual-hosted git repository.
gregdove pushed a commit to branch develop
in repository https://gitbox.apache.org/repos/asf/royale-asjs.git
The following commit(s) were added to refs/heads/develop by this push:
new 6f6ee47 Fix an XML regression in XML.elements query. Added test coverage for this.
6f6ee47 is described below
commit 6f6ee47b0209a11b07c10d7f9225b60b4e48aafc
Author: greg-dove <gr...@gmail.com>
AuthorDate: Wed Jun 10 09:53:22 2020 +1200
Fix an XML regression in XML.elements query. Added test coverage for this.
---
frameworks/projects/XML/src/main/royale/XML.as | 2 +-
.../flexUnitTests/xml/XMLTesterGeneralTest.as | 29 ++++++++++++++++++++++
2 files changed, 30 insertions(+), 1 deletion(-)
diff --git a/frameworks/projects/XML/src/main/royale/XML.as b/frameworks/projects/XML/src/main/royale/XML.as
index b854bc8..5acf21e 100644
--- a/frameworks/projects/XML/src/main/royale/XML.as
+++ b/frameworks/projects/XML/src/main/royale/XML.as
@@ -1299,7 +1299,7 @@ package
var len:int = childrenLength();
for(i=0;i<len;i++)
{
- if(_children[i].getNodeRef == ELEMENT && (all || name.matches(_children[i].name())))
+ if(_children[i].getNodeRef() == ELEMENT && (all || name.matches(_children[i].name())))
list.append(_children[i]);
}
diff --git a/frameworks/projects/XML/src/test/royale/flexUnitTests/xml/XMLTesterGeneralTest.as b/frameworks/projects/XML/src/test/royale/flexUnitTests/xml/XMLTesterGeneralTest.as
index 0e07414..d4663a5 100644
--- a/frameworks/projects/XML/src/test/royale/flexUnitTests/xml/XMLTesterGeneralTest.as
+++ b/frameworks/projects/XML/src/test/royale/flexUnitTests/xml/XMLTesterGeneralTest.as
@@ -1124,6 +1124,35 @@ package flexUnitTests.xml
}
[Test]
+ public function testElements():void{
+ XML.setSettings(XML.defaultSettings());
+ var xml:XML = <root> <test/><?foo bar?>Something<el1/><!-- comment --> surrounded With Whitespace <el2/></root>;
+
+
+ var elements:XMLList = xml.elements();
+
+
+ assertEquals(
+ elements.toString(),
+ '<test/>\n' +
+ '<el1/>\n' +
+ '<el2/>', 'elements only should be 3 elements');
+
+ elements = xml.elements('el1')
+ assertEquals(
+ elements.toXMLString(),
+ '<el1/>', 'elements query should return 1 element');
+
+ var el:XML = <el1/>;
+ xml.appendChild(el)
+
+ elements = xml.elements('el1')
+ assertEquals(
+ elements.toXMLString(),
+ '<el1/>\n<el1/>', 'elements query should return 2 elements');
+ }
+
+ [Test]
public function testDelete():void{
XML.setSettings(XML.defaultSettings());
XML.prettyPrinting = false;