You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "betodealmeida (via GitHub)" <gi...@apache.org> on 2023/06/29 01:14:55 UTC

[GitHub] [superset] betodealmeida opened a new pull request, #24548: fix: heads

betodealmeida opened a new pull request, #24548:
URL: https://github.com/apache/superset/pull/24548

   <!---
   Please write the PR title following the conventions at https://www.conventionalcommits.org/en/v1.0.0/
   Example:
   fix(dashboard): load charts correctly
   -->
   
   ### SUMMARY
   <!--- Describe the change below, including rationale and design decisions -->
   
   Merge Alembic heads manually.
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   <!--- Skip this if not applicable -->
   
   ### TESTING INSTRUCTIONS
   <!--- Required! What steps can be taken to manually verify the changes? -->
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [ ] Has associated issue:
   - [ ] Required feature flags:
   - [ ] Changes UI
   - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
     - [ ] Migration is atomic, supports rollback & is backwards-compatible
     - [ ] Confirm DB migration upgrade and downgrade tested
     - [ ] Runtime estimates and downtime expectations provided
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] codecov[bot] commented on pull request #24548: fix: heads

Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #24548:
URL: https://github.com/apache/superset/pull/24548#issuecomment-1612312435

   ## [Codecov](https://app.codecov.io/gh/apache/superset/pull/24548?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   > Merging [#24548](https://app.codecov.io/gh/apache/superset/pull/24548?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (74faca5) into [master](https://app.codecov.io/gh/apache/superset/commit/75543af5504c13dbd60bc6d327efb9700e459a51?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (75543af) will **increase** coverage by `12.02%`.
   > The diff coverage is `n/a`.
   
   > :exclamation: Current head 74faca5 differs from pull request most recent head 07500ad. Consider uploading reports for the commit 07500ad to get more accurate results
   
   ```diff
   @@             Coverage Diff             @@
   ##           master   #24548       +/-   ##
   ===========================================
   + Coverage   55.26%   67.29%   +12.02%     
   ===========================================
     Files        1906     1906               
     Lines       74114    74114               
     Branches     8155     8155               
   ===========================================
   + Hits        40959    49873     +8914     
   + Misses      31036    22122     -8914     
     Partials     2119     2119               
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | hive | `53.92% <ø> (?)` | |
   | mysql | `79.40% <ø> (?)` | |
   | postgres | `79.49% <ø> (?)` | |
   | python | `79.75% <ø> (+25.05%)` | :arrow_up: |
   | unit | `?` | |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   [see 376 files with indirect coverage changes](https://app.codecov.io/gh/apache/superset/pull/24548/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   
   :mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] john-bodley commented on pull request #24548: fix: heads

Posted by "john-bodley (via GitHub)" <gi...@apache.org>.
john-bodley commented on PR #24548:
URL: https://github.com/apache/superset/pull/24548#issuecomment-1612305076

   Thanks @betodealmeida.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] betodealmeida merged pull request #24548: fix: heads

Posted by "betodealmeida (via GitHub)" <gi...@apache.org>.
betodealmeida merged PR #24548:
URL: https://github.com/apache/superset/pull/24548


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org