[GitHub] [spark] gengliangwang commented on a change in pull request #33085: [SPARK-35894][BUILD] Introduce new style enforce to not import scala.collection.Seq/IndexedSeq

[GitBox <gi...@apache.org>]

gengliangwang commented on a change in pull request #33085:
URL: https://github.com/apache/spark/pull/33085#discussion_r658756220



##########
File path: scalastyle-config.xml
##########
@@ -323,6 +323,18 @@ This file is divided into 3 sections:
 
   <check level="error" class="org.scalastyle.scalariform.DeprecatedJavaChecker" enabled="true"></check>
 
+  <check level="error" class="org.scalastyle.scalariform.IllegalImportsChecker" enabled="true">
+    <parameters><parameter name="illegalImports"><![CDATA[scala.collection.Seq,scala.collection.IndexedSeq]]></parameter></parameters>
+    <customMessage><![CDATA[
+      Don't import scala.collection.Seq and scala.collection.IndexedSeq as it may bring some problems with cross-build between Scala 2.12 and 2.13.

Review comment:
       ```suggestion
         Don't import scala.collection.Seq or scala.collection.IndexedSeq as they may bring some problems with the cross-building between Scala 2.12 and 2.13.
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org