[GitHub] [pinot] mcvsubbu commented on a change in pull request #8103: add segment zk metadata check before creating a table

[GitBox <gi...@apache.org>]

mcvsubbu commented on a change in pull request #8103:
URL: https://github.com/apache/pinot/pull/8103#discussion_r797045859



##########
File path: pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/PinotHelixResourceManager.java
##########
@@ -1270,6 +1270,11 @@ public void addTable(TableConfig tableConfig)
         if (getAllTables().contains(tableNameWithType)) {
           throw new TableAlreadyExistsException("Table " + tableNameWithType + " already exists");
         }
+        List<SegmentZKMetadata> segmentsZKMetadata = getSegmentsZKMetadata(tableNameWithType);

Review comment:
       If you list things out, please limit the list size to (say) 5 segments. You can indicate in the message that there are more (e.g. `...` could be used).




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org