[jira] [Commented] (ZOOKEEPER-1719) zkCli.sh, zkServer.sh and zkEnv.sh regression caused by ZOOKEEPER-1663

["Hudson (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/ZOOKEEPER-1719?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14074297#comment-14074297 ] 

Hudson commented on ZOOKEEPER-1719:
-----------------------------------

SUCCESS: Integrated in ZooKeeper-trunk #2385 (See [https://builds.apache.org/job/ZooKeeper-trunk/2385/])
ZOOKEEPER-1937. init script needs fixing for ZOOKEEPER-1719 (Marshall McMullen via phunt) (phunt: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1613326)
* /zookeeper/trunk/CHANGES.txt
* /zookeeper/trunk/src/packages/rpm/init.d/zookeeper


> zkCli.sh, zkServer.sh and zkEnv.sh regression caused by ZOOKEEPER-1663
> ----------------------------------------------------------------------
>
>                 Key: ZOOKEEPER-1719
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1719
>             Project: ZooKeeper
>          Issue Type: Bug
>    Affects Versions: 3.4.5, 3.5.0
>         Environment: Linux (Ubuntu 12.04) with dash shell
>            Reporter: Marshall McMullen
>            Assignee: Marshall McMullen
>             Fix For: 3.4.6, 3.5.0
>
>         Attachments: ZOOKEEPER-1719.patch
>
>
> This fix from ZOOKEEPER-1663 is incorrect. It assumes the shell is bash since it uses bash array construction, e.g.:
> {code}
>  96   LIBPATH=("${ZOOKEEPER_PREFIX}"/share/zookeeper/*.jar)
> {code}
> This does NOT work if /bin/sh points to /bin/dash as it does on Ubuntu. 
> It fails as so:
> {quote}
> zkEnv.sh: 96: zkEnv.sh: Syntax error: "(" unexpected (expecting "fi")                                                                                                                                                                                              
> {quote}
> If I change the shebang at the top to use "/bin/bash" instead of "/bin/sh" it works as expected. I don't know the full details of why using a bash array was chosen as the solution but I don't think it is the right way to deal with spaces in these paths...



--
This message was sent by Atlassian JIRA
(v6.2#6252)