You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2022/07/19 11:01:04 UTC

[GitHub] [tvm] leandron opened a new pull request, #12131: [TFLite][CI] Update TensorFlow dependency to 2.9.1

leandron opened a new pull request, #12131:
URL: https://github.com/apache/tvm/pull/12131

   This updates the TF version to be used in TVM CI to 2.9.1, which brings improvements so that more platforms are supported by official packages. This PR updates the Docker images scripting to install TF and TFLite.
   
   Adding it here as a draft until we get #12130 merged.
   
   cc @areusch @Mousius @driazati @NicolaLancellotti for reviews
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] leandron commented on a diff in pull request #12131: [TFLite][CI] Update TensorFlow dependency to 2.9.1

Posted by GitBox <gi...@apache.org>.
leandron commented on code in PR #12131:
URL: https://github.com/apache/tvm/pull/12131#discussion_r961891538


##########
docker/install/ubuntu_install_cmake_source.sh:
##########
@@ -20,8 +20,8 @@ set -e
 set -u
 set -o pipefail
 
-v=3.14
-version=3.14.7
+v=3.22

Review Comment:
   3.18 is also accepted by tflite. Will do the change here and notify.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] driazati commented on a diff in pull request #12131: [TFLite][CI] Update TensorFlow dependency to 2.9.1

Posted by GitBox <gi...@apache.org>.
driazati commented on code in PR #12131:
URL: https://github.com/apache/tvm/pull/12131#discussion_r961872488


##########
docker/install/ubuntu_install_tflite.sh:
##########
@@ -38,8 +39,16 @@ pip3 install flatbuffers
 # The library is built at:
 # tensorflow/tensorflow/lite/tools/make/gen/*/lib/libtensorflow-lite.a.
 git clone https://github.com/tensorflow/tensorflow --branch=v${TENSORFLOW_VERSION} --depth 1
-./tensorflow/tensorflow/lite/tools/make/download_dependencies.sh
-./tensorflow/tensorflow/lite/tools/make/build_lib.sh
+
+mkdir -p /opt/tflite
+cd /opt/tflite
+cmake \
+  -DTFLITE_ENABLE_XNNPACK=OFF \
+  /tensorflow/tensorflow/lite
+
+cmake --build .

Review Comment:
   ```suggestion
   cmake --build . -- -j"$(nproc)"
   ```



##########
docker/install/ubuntu_install_cmake_source.sh:
##########
@@ -20,8 +20,8 @@ set -e
 set -u
 set -o pipefail
 
-v=3.14
-version=3.14.7
+v=3.22

Review Comment:
   does tflite require 3.22? #12682 is also trying to update the CMake version to 3.18 and we should pick the lower of the two for what runs in CI (if possible)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] areusch commented on pull request #12131: [TFLite][CI] Update TensorFlow dependency to 2.9.1

Posted by GitBox <gi...@apache.org>.
areusch commented on PR #12131:
URL: https://github.com/apache/tvm/pull/12131#issuecomment-1193576031

   @leandron when investigating the Python deps I also came across this bug. We currently build a tflite library from the tensorflow source, and in TF 2.7 the build system was switched to CMake I believe. I haven't yet had time to solve this, but I'll let you know if I do.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] leandron commented on pull request #12131: [TFLite][CI] Update TensorFlow dependency to 2.9.1

Posted by GitBox <gi...@apache.org>.
leandron commented on PR #12131:
URL: https://github.com/apache/tvm/pull/12131#issuecomment-1235655909

   @areusch just to update here as we're discussing, once this is merged, the PR that updates the Docker images, will need to update `task_config_build_cpu.sh` from:
   ```
   echo set\(USE_TFLITE ON\) >> config.cmake
   ```
   
   to:
   
   ```
   echo set\(USE_TFLITE /opt/tflite\) >> config.cmake
   ```
   
   This way we keep the default source based installation in the new format introduced here.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] mbrookhart commented on a diff in pull request #12131: [TFLite][CI] Update TensorFlow dependency to 2.9.1

Posted by GitBox <gi...@apache.org>.
mbrookhart commented on code in PR #12131:
URL: https://github.com/apache/tvm/pull/12131#discussion_r961861487


##########
docker/Dockerfile.ci_cpu:
##########
@@ -136,3 +139,7 @@ ENV PATH /opt/sccache:$PATH
 # Libxsmm deps
 COPY install/ubuntu_install_libxsmm.sh /install
 RUN bash /install/ubuntu_install_libxsmm.sh
+
+# Hacky workaround (do not push to GitHub) to install the right Numpy version

Review Comment:
   Little concered about a comment that says "do not push to Github" in a github PR...



##########
docker/install/ubuntu_install_cmake_source.sh:
##########
@@ -20,8 +20,8 @@ set -e
 set -u
 set -o pipefail
 
-v=3.14
-version=3.14.7
+v=3.22

Review Comment:
   Do we need to update the minimum cmake version in the cmake file?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] leandron commented on a diff in pull request #12131: [TFLite][CI] Update TensorFlow dependency to 2.9.1

Posted by GitBox <gi...@apache.org>.
leandron commented on code in PR #12131:
URL: https://github.com/apache/tvm/pull/12131#discussion_r961907170


##########
docker/Dockerfile.ci_cpu:
##########
@@ -136,3 +139,7 @@ ENV PATH /opt/sccache:$PATH
 # Libxsmm deps
 COPY install/ubuntu_install_libxsmm.sh /install
 RUN bash /install/ubuntu_install_libxsmm.sh
+
+# Hacky workaround (do not push to GitHub) to install the right Numpy version

Review Comment:
   Oops! Removed now. For context: this we needed before I realised that `ethos-u-vela` needed to be upgraded, which had a hard requirement on an old numpy. With that, this workaround was not needed anymore.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] areusch commented on pull request #12131: [TFLite][CI] Update TensorFlow dependency to 2.9.1

Posted by GitBox <gi...@apache.org>.
areusch commented on PR #12131:
URL: https://github.com/apache/tvm/pull/12131#issuecomment-1239809182

   thanks @leandron !!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] driazati commented on a diff in pull request #12131: [TFLite][CI] Update TensorFlow dependency to 2.9.1

Posted by GitBox <gi...@apache.org>.
driazati commented on code in PR #12131:
URL: https://github.com/apache/tvm/pull/12131#discussion_r961922616


##########
docker/install/ubuntu_install_cmake_source.sh:
##########
@@ -20,8 +20,8 @@ set -e
 set -u
 set -o pipefail
 
-v=3.14
-version=3.14.7
+v=3.22

Review Comment:
   looks like this also needs to change to get a valid URL below
   ```suggestion
   v=3.18
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] leandron commented on pull request #12131: [TFLite][CI] Update TensorFlow dependency to 2.9.1

Posted by GitBox <gi...@apache.org>.
leandron commented on PR #12131:
URL: https://github.com/apache/tvm/pull/12131#issuecomment-1194573947

   Yes. However it still requires the Docker images to have the updated TF for the whole CI.
   
   I generated a new set, and will make a new CI staging run with the new images. Then it should be fine.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] leandron commented on pull request #12131: [TFLite][CI] Update TensorFlow dependency to 2.9.1

Posted by GitBox <gi...@apache.org>.
leandron commented on PR #12131:
URL: https://github.com/apache/tvm/pull/12131#issuecomment-1193757858

   > @leandron when investigating the Python deps I also came across this bug. We currently build a tflite library from the tensorflow source, and in TF 2.7 the build system was switched to CMake I believe. I haven't yet had time to solve this, but I'll let you know if I do.
   
   This is solved in this PR. The only issue is that the CI is testing with the old images. I'll generate a new set from `ci-docker-staging` and re-run the tests. it should be fine.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] areusch commented on pull request #12131: [TFLite][CI] Update TensorFlow dependency to 2.9.1

Posted by GitBox <gi...@apache.org>.
areusch commented on PR #12131:
URL: https://github.com/apache/tvm/pull/12131#issuecomment-1235682917

   @mbrookhart could you have a look?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] areusch commented on pull request #12131: [TFLite][CI] Update TensorFlow dependency to 2.9.1

Posted by GitBox <gi...@apache.org>.
areusch commented on PR #12131:
URL: https://github.com/apache/tvm/pull/12131#issuecomment-1194863593

   ah ok cool--lmk when i can take a look at them


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] leandron commented on pull request #12131: [TFLite][CI] Update TensorFlow dependency to 2.9.1

Posted by GitBox <gi...@apache.org>.
leandron commented on PR #12131:
URL: https://github.com/apache/tvm/pull/12131#issuecomment-1236741003

   @tvm-bot rerun


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] leandron commented on pull request #12131: [TFLite][CI] Update TensorFlow dependency to 2.9.1

Posted by GitBox <gi...@apache.org>.
leandron commented on PR #12131:
URL: https://github.com/apache/tvm/pull/12131#issuecomment-1239765332

   > Looks good to me, just wanted to mention that this might break microTVM testing on hardware since RVM uses a different tensorflow version. If it does we need a follow up PR.
   > 
   > https://github.com/apache/tvm/blob/2622ac9e638b259cae017813ad93937c0ff8a2f9/apps/microtvm/pyproject.toml#L107
   
   Did this change recently? I’ve run many test rounds and haven’t seen any breakage in microtvm


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] leandron commented on pull request #12131: [TFLite][CI] Update TensorFlow dependency to 2.9.1

Posted by GitBox <gi...@apache.org>.
leandron commented on PR #12131:
URL: https://github.com/apache/tvm/pull/12131#issuecomment-1235803446

   > lgtm once comments are addressed
   
   Thanks @driazati 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] mehrdadh commented on pull request #12131: [TFLite][CI] Update TensorFlow dependency to 2.9.1

Posted by GitBox <gi...@apache.org>.
mehrdadh commented on PR #12131:
URL: https://github.com/apache/tvm/pull/12131#issuecomment-1239762643

   Looks good to me, just wanted to mention that this might break microTVM testing on hardware since RVM uses a different tensorflow version:
   https://github.com/apache/tvm/blob/2622ac9e638b259cae017813ad93937c0ff8a2f9/apps/microtvm/pyproject.toml#L107


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] mehrdadh commented on pull request #12131: [TFLite][CI] Update TensorFlow dependency to 2.9.1

Posted by GitBox <gi...@apache.org>.
mehrdadh commented on PR #12131:
URL: https://github.com/apache/tvm/pull/12131#issuecomment-1239864128

   @leandron I don't think it changed recently, it should be fine


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] areusch commented on pull request #12131: [TFLite][CI] Update TensorFlow dependency to 2.9.1

Posted by GitBox <gi...@apache.org>.
areusch commented on PR #12131:
URL: https://github.com/apache/tvm/pull/12131#issuecomment-1194515992

   hm, was that https://ci.tlcpack.ai/blue/organizations/jenkins/docker-images-ci%2Fdocker-image-run-tests/detail/docker-image-run-tests/171/pipeline?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] leandron commented on pull request #12131: [TFLite][CI] Update TensorFlow dependency to 2.9.1

Posted by GitBox <gi...@apache.org>.
leandron commented on PR #12131:
URL: https://github.com/apache/tvm/pull/12131#issuecomment-1235930749

   @tvm-bot rerun


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] leandron commented on a diff in pull request #12131: [TFLite][CI] Update TensorFlow dependency to 2.9.1

Posted by GitBox <gi...@apache.org>.
leandron commented on code in PR #12131:
URL: https://github.com/apache/tvm/pull/12131#discussion_r961871579


##########
docker/install/ubuntu_install_cmake_source.sh:
##########
@@ -20,8 +20,8 @@ set -e
 set -u
 set -o pipefail
 
-v=3.14
-version=3.14.7
+v=3.22

Review Comment:
   No because the update is only required by tflite build, not TVM



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] areusch merged pull request #12131: [TFLite][CI] Update TensorFlow dependency to 2.9.1

Posted by GitBox <gi...@apache.org>.
areusch merged PR #12131:
URL: https://github.com/apache/tvm/pull/12131


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org