You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@solr.apache.org by GitBox <gi...@apache.org> on 2022/01/12 16:22:23 UTC

[GitHub] [solr] HoustonPutman commented on pull request #512: SOLR-15209: Make the LegacyAssignStrategy the DefaultPlacementPlugin

HoustonPutman commented on pull request #512:
URL: https://github.com/apache/solr/pull/512#issuecomment-1011222062


   > I see you're considering [SOLR-15209](https://issues.apache.org/jira/browse/SOLR-15209) as making `LegacyAssignStrategy` the default placement, when it originally was (and still is in Jira) "Make the AffinityPlacementFactory the default placement plugin".
   
   Fair enough, I thought about creating a new ticket, which I still can. I ended up not because making the legacy strategy a plugin, like the rest, was a part of the description. If you would like a new JIRA to track this, so that [SOLR-15209](https://issues.apache.org/jira/browse/SOLR-15209) can be used to track changing the default, I am happy to make the new one and link it 🙂 
   
   > The original goal of [SOLR-15209](https://issues.apache.org/jira/browse/SOLR-15209) was to make the realistic placement strategy (affinity placement) the default one to 1. have better/more flexible placement overall, and 2. make sure this code is running (in installations, in tests) to find issues with it.
   
   We can always do this (even under a different ticket), then decide to change the default implementation separately. I'm perfectly fine with that as long as we test how the performance of cluster operations are affected.
   
   But I definitely agree that there should be more tests around these. (I think while writing this, I found some issues that I will surface in new JIRAs)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org