[GitHub] qiuchenjian commented on a change in pull request #3096: [CARBONDATA-3267]Fixed Range Sort OOM Issue

[GitBox <gi...@apache.org>]

qiuchenjian commented on a change in pull request #3096: [CARBONDATA-3267]Fixed Range Sort OOM Issue 
URL: https://github.com/apache/carbondata/pull/3096#discussion_r250429748
 
 

 ##########
 File path: core/src/main/java/org/apache/carbondata/core/memory/IntPointerBuffer.java
 ##########
 @@ -75,17 +75,17 @@ public int get(int rowId) {
   }
 
   public void loadToUnsafe() {
-    try {
-      pointerMemoryBlock =
-          UnsafeSortMemoryManager.allocateMemoryWithRetry(this.taskId, pointerBlock.length * 4);
+    pointerMemoryBlock =
+        UnsafeSortMemoryManager.INSTANCE.allocateMemory(this.taskId, pointerBlock.length * 4);
+    // pointerMemoryBlock it means sort storage memory manager does not have space to loaf pointer
+    // buffer in that case use pointerBlock
+    if (null != pointerMemoryBlock) {
 
 Review comment:
   get your idea, but how do we know  we didn't get the sort storeage memory in fact cluster?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services