You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@paimon.apache.org by "yangjf2019 (via GitHub)" <gi...@apache.org> on 2025/03/31 06:36:47 UTC

[PR] [test] Remove this public modifier for junit5 Test [paimon]

yangjf2019 opened a new pull request, #5374:
URL: https://github.com/apache/paimon/pull/5374

   <!-- Please specify the module before the PR name: [core] ... or [flink] ... -->
   
   ### Purpose
   
   <!-- Linking this pull request to the issue -->
   JUnit5 is more tolerant regarding the visibilities of Test classes than JUnit4, which required everything to be public.So, we can consider removing this `public` modifier for all the junit5 Test.
   Refer to this [link](https://junit.org/junit5/docs/current/user-guide/#writing-tests-test-interfaces-and-default-methods).
   
   <img width="1615" alt="123" src="https://github.com/user-attachments/assets/d7d04cc8-bb8b-4ee7-8468-1d700d89da34" />
   
   <!-- What is the purpose of the change -->
   
   ### Tests
   
   <!-- List UT and IT cases to verify this change -->
   
   ### API and Format
   
   <!-- Does this change affect API or storage format -->
   
   ### Documentation
   
   <!-- Does this change introduce a new feature -->
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [test] Remove this public modifier for junit5 Test [paimon]

Posted by "LinMingQiang (via GitHub)" <gi...@apache.org>.
LinMingQiang commented on PR #5374:
URL: https://github.com/apache/paimon/pull/5374#issuecomment-2771115836

   You can first create an issue next time to seek suggestions. Can reduce unnecessary workload.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [test] Remove this public modifier for junit5 Test [paimon]

Posted by "yangjf2019 (via GitHub)" <gi...@apache.org>.
yangjf2019 commented on PR #5374:
URL: https://github.com/apache/paimon/pull/5374#issuecomment-2767936329

   > Hi @yangjf2019, may I ask about the motivation of pushing forward this PR? Junit5 supports non-public test methods, but it does not provides the necessity of setting all test methods to non-public.
   
   Thanks for your comment!Since the [previous tweaks](https://github.com/apache/paimon/pull/5338) were not perfect, I think some of paimon's test modules could be considered for upgrading to JUnit5 and AssertJ.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [test] Remove this public modifier for junit5 Test [paimon]

Posted by "yangjf2019 (via GitHub)" <gi...@apache.org>.
yangjf2019 commented on PR #5374:
URL: https://github.com/apache/paimon/pull/5374#issuecomment-2771042247

   If it is unneccessary, I will close the PR.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [test] Remove this public modifier for junit5 Test [paimon]

Posted by "yangjf2019 (via GitHub)" <gi...@apache.org>.
yangjf2019 commented on PR #5374:
URL: https://github.com/apache/paimon/pull/5374#issuecomment-2771240723

   Okay,Thanks @JingsongLi @LinMingQiang 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [test] Remove this public modifier for junit5 Test [paimon]

Posted by "JingsongLi (via GitHub)" <gi...@apache.org>.
JingsongLi closed pull request #5374: [test] Remove this public modifier for junit5 Test
URL: https://github.com/apache/paimon/pull/5374


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [test] Remove this public modifier for junit5 Test [paimon]

Posted by "yunfengzhou-hub (via GitHub)" <gi...@apache.org>.
yunfengzhou-hub commented on PR #5374:
URL: https://github.com/apache/paimon/pull/5374#issuecomment-2771093698

   > If it is unneccessary, I will close the PR.How do you see?
   
   I'm not sure. @JingsongLi could you please take a look at this PR?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [test] Remove this public modifier for junit5 Test [paimon]

Posted by "JingsongLi (via GitHub)" <gi...@apache.org>.
JingsongLi commented on PR #5374:
URL: https://github.com/apache/paimon/pull/5374#issuecomment-2771107523

   If you still want to continue the discussion, you can send an email to the dev list, and I will close this PR for now.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [test] Remove this public modifier for junit5 Test [paimon]

Posted by "yangjf2019 (via GitHub)" <gi...@apache.org>.
yangjf2019 commented on PR #5374:
URL: https://github.com/apache/paimon/pull/5374#issuecomment-2765732563

   CC @yunfengzhou-hub , @JingsongLi ,Please take a look in your spare time,thank you very much!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [test] Remove this public modifier for junit5 Test [paimon]

Posted by "yunfengzhou-hub (via GitHub)" <gi...@apache.org>.
yunfengzhou-hub commented on PR #5374:
URL: https://github.com/apache/paimon/pull/5374#issuecomment-2767917791

   Hi @yangjf2019, may I ask about the motivation of pushing forward this PR? Junit5 supports non-public test methods, but it does not provides the necessity of setting all test methods to non-public.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [test] Remove this public modifier for junit5 Test [paimon]

Posted by "JingsongLi (via GitHub)" <gi...@apache.org>.
JingsongLi commented on PR #5374:
URL: https://github.com/apache/paimon/pull/5374#issuecomment-2771105705

   Hi @yangjf2019 , this PR contains 3100+ codes, it requires a lot of effort to review it.
   But what is its use for us? And this modification also blocks the possibility of reusing related projects for testing.
   
   I don't think it's necessary to push forward with this PR.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org