You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geode.apache.org by Kirk Lund <ki...@gmail.com> on 2016/06/18 03:03:11 UTC

Review Request 48899: GEODE-1565: disable GemfireDataCommandsDUnitTest over HTTP

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48899/
-----------------------------------------------------------

Review request for geode, Anthony Baker, Grace Meilen, and Jinmei Liao.


Bugs: GEODE-1565
    https://issues.apache.org/jira/browse/GEODE-1565


Repository: geode


Description
-------

GEODE-1565: disable GemfireDataCommandsDUnitTest over HTTP

CommandOverHttpDUnitTest runs GemfireDataCommandsDUnitTest over HTTP and the following tests fail:

* testRebalanceCommandForSimulateWithNoMember
* testRebalanceCommandForSimulate
* testRebalanceForExcludeRegionFunction
* testRebalanceForIncludeRegionFunction
* testSimulateForEntireDS

These tests will fail 100% in nightly build, precheckin and flakyTest until GEODE-1565 is fixed.

They appear to fail due to fixing GEODE-835 (replacing geode-joptsimple with jopt-simple dependency). Next step is to determine why the rebalance commands fail after the change to jopt-simple and fix the problem.


Diffs
-----

  geode-web/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/CommandOverHttpDUnitTest.java 6cc475e 

Diff: https://reviews.apache.org/r/48899/diff/


Testing
-------

CommandOverHttpDUnitTest, CommandOverHttpDUnitTest


Thanks,

Kirk Lund


Re: Review Request 48899: GEODE-1565: disable GemfireDataCommandsDUnitTest over HTTP

Posted by Kirk Lund <ki...@gmail.com>.

> On June 18, 2016, 6:11 p.m., Hitesh Khamesra wrote:
> > Ship It!

Thanks for the weekend review Hitesh!


- Kirk


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48899/#review138422
-----------------------------------------------------------


On June 18, 2016, 3:03 a.m., Kirk Lund wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48899/
> -----------------------------------------------------------
> 
> (Updated June 18, 2016, 3:03 a.m.)
> 
> 
> Review request for geode, Anthony Baker, Grace Meilen, and Jinmei Liao.
> 
> 
> Bugs: GEODE-1565
>     https://issues.apache.org/jira/browse/GEODE-1565
> 
> 
> Repository: geode
> 
> 
> Description
> -------
> 
> GEODE-1565: disable GemfireDataCommandsDUnitTest over HTTP
> 
> CommandOverHttpDUnitTest runs GemfireDataCommandsDUnitTest over HTTP and the following tests fail:
> 
> * testRebalanceCommandForSimulateWithNoMember
> * testRebalanceCommandForSimulate
> * testRebalanceForExcludeRegionFunction
> * testRebalanceForIncludeRegionFunction
> * testSimulateForEntireDS
> 
> These tests will fail 100% in nightly build, precheckin and flakyTest until GEODE-1565 is fixed.
> 
> They appear to fail due to fixing GEODE-835 (replacing geode-joptsimple with jopt-simple dependency). Next step is to determine why the rebalance commands fail after the change to jopt-simple and fix the problem.
> 
> 
> Diffs
> -----
> 
>   geode-web/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/CommandOverHttpDUnitTest.java 6cc475e 
> 
> Diff: https://reviews.apache.org/r/48899/diff/
> 
> 
> Testing
> -------
> 
> CommandOverHttpDUnitTest, CommandOverHttpDUnitTest
> 
> 
> Thanks,
> 
> Kirk Lund
> 
>


Re: Review Request 48899: GEODE-1565: disable GemfireDataCommandsDUnitTest over HTTP

Posted by Hitesh Khamesra <hk...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48899/#review138422
-----------------------------------------------------------


Ship it!




Ship It!

- Hitesh Khamesra


On June 18, 2016, 3:03 a.m., Kirk Lund wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48899/
> -----------------------------------------------------------
> 
> (Updated June 18, 2016, 3:03 a.m.)
> 
> 
> Review request for geode, Anthony Baker, Grace Meilen, and Jinmei Liao.
> 
> 
> Bugs: GEODE-1565
>     https://issues.apache.org/jira/browse/GEODE-1565
> 
> 
> Repository: geode
> 
> 
> Description
> -------
> 
> GEODE-1565: disable GemfireDataCommandsDUnitTest over HTTP
> 
> CommandOverHttpDUnitTest runs GemfireDataCommandsDUnitTest over HTTP and the following tests fail:
> 
> * testRebalanceCommandForSimulateWithNoMember
> * testRebalanceCommandForSimulate
> * testRebalanceForExcludeRegionFunction
> * testRebalanceForIncludeRegionFunction
> * testSimulateForEntireDS
> 
> These tests will fail 100% in nightly build, precheckin and flakyTest until GEODE-1565 is fixed.
> 
> They appear to fail due to fixing GEODE-835 (replacing geode-joptsimple with jopt-simple dependency). Next step is to determine why the rebalance commands fail after the change to jopt-simple and fix the problem.
> 
> 
> Diffs
> -----
> 
>   geode-web/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/CommandOverHttpDUnitTest.java 6cc475e 
> 
> Diff: https://reviews.apache.org/r/48899/diff/
> 
> 
> Testing
> -------
> 
> CommandOverHttpDUnitTest, CommandOverHttpDUnitTest
> 
> 
> Thanks,
> 
> Kirk Lund
> 
>