You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2022/01/25 16:05:13 UTC

[GitHub] [incubator-nuttx] jerpelea commented on a change in pull request #5295: sim: Added Kconfig option for UART buffer size.

jerpelea commented on a change in pull request #5295:
URL: https://github.com/apache/incubator-nuttx/pull/5295#discussion_r791871531



##########
File path: arch/sim/src/sim/up_uart.c
##########
@@ -31,12 +31,16 @@
 
 #include "up_internal.h"
 
-#if defined(USE_DEVCONSOLE) || CONFIG_SIM_UART_NUMBER > 0
+#if defined(USE_DEVCONSOLE) || defined(CONFIG_SIM_UART)
 /****************************************************************************
  * Pre-processor Definitions
  ****************************************************************************/
 
-#define BUFSIZE 256
+#ifdef CONFIG_SIM_UART_BUFFER_SIZE

Review comment:
       @fjpanag please change to 
   #ifndef CONFIG_SIM_UART_BUFFER_SIZE
   # define CONFIG_SIM_UART_BUFFER_SIZE 256
   #endif
   as @pkarashchenko suggested
   
   there is no need to keep the BUFSIZE




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org