You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2022/10/31 18:35:07 UTC

[GitHub] [tvm] vinx13 opened a new pull request, #13243: [MetaSchedule] Fix thread bindings of MultiLevelTilingTensorCore

vinx13 opened a new pull request, #13243:
URL: https://github.com/apache/tvm/pull/13243

   Fixed https://github.com/apache/tvm/issues/13204.
   
   cc @junrushao 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [tvm] tvm-bot commented on pull request #13243: [MetaSchedule] Fix thread bindings of MultiLevelTilingTensorCore

Posted by GitBox <gi...@apache.org>.
tvm-bot commented on PR #13243:
URL: https://github.com/apache/tvm/pull/13243#issuecomment-1297506930

   <!---bot-comment-->
   
   Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from [Reviewers](https://github.com/apache/incubator-tvm/blob/master/CONTRIBUTORS.md#reviewers) by @-ing them in a comment.
   
   <!--bot-comment-ccs-start-->
    * cc @Hzfengsy, @elvin-n, @junrushao <sub>See [#10317](https://github.com/apache/tvm/issues/10317) for details</sub><!--bot-comment-ccs-end-->
   
   <sub>Generated by [tvm-bot](https://github.com/apache/tvm/blob/main/ci/README.md#github-actions)</sub>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [tvm] masahi commented on pull request #13243: [MetaSchedule] Fix thread bindings of MultiLevelTilingTensorCore

Posted by GitBox <gi...@apache.org>.
masahi commented on PR #13243:
URL: https://github.com/apache/tvm/pull/13243#issuecomment-1297721920

   @tvm-bot rerun


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [tvm] csullivan commented on a diff in pull request #13243: [MetaSchedule] Fix thread bindings of MultiLevelTilingTensorCore

Posted by GitBox <gi...@apache.org>.
csullivan commented on code in PR #13243:
URL: https://github.com/apache/tvm/pull/13243#discussion_r1009903904


##########
src/meta_schedule/schedule_rule/multi_level_tiling_tensor_core.cc:
##########
@@ -556,6 +556,11 @@ ScheduleRule ScheduleRule::MultiLevelTilingTensorCore(
     Optional<Integer> max_innermost_factor, Optional<Array<Integer>> vector_load_lens,
     Optional<Map<String, ObjectRef>> reuse_read, Optional<Map<String, ObjectRef>> reuse_write,
     bool use_software_pipeline) {
+  if (tile_binds.defined()) {
+    for (const String& tile_bind : tile_binds.value()) {
+      CHECK_NE(tile_bind, "threadIdx.x") << "Cannot bind to threadIdx.x when using tensor core.";
+    }
+  }

Review Comment:
   Oops looks like @junrushao already asked my question, I trust the your judgements :)



##########
src/meta_schedule/schedule_rule/multi_level_tiling_tensor_core.cc:
##########
@@ -556,6 +556,11 @@ ScheduleRule ScheduleRule::MultiLevelTilingTensorCore(
     Optional<Integer> max_innermost_factor, Optional<Array<Integer>> vector_load_lens,
     Optional<Map<String, ObjectRef>> reuse_read, Optional<Map<String, ObjectRef>> reuse_write,
     bool use_software_pipeline) {
+  if (tile_binds.defined()) {
+    for (const String& tile_bind : tile_binds.value()) {
+      CHECK_NE(tile_bind, "threadIdx.x") << "Cannot bind to threadIdx.x when using tensor core.";
+    }
+  }

Review Comment:
   Oops looks like @junrushao already asked my question, I trust your judgements :)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [tvm] vinx13 commented on a diff in pull request #13243: [MetaSchedule] Fix thread bindings of MultiLevelTilingTensorCore

Posted by GitBox <gi...@apache.org>.
vinx13 commented on code in PR #13243:
URL: https://github.com/apache/tvm/pull/13243#discussion_r1009905506


##########
src/meta_schedule/schedule_rule/multi_level_tiling_tensor_core.cc:
##########
@@ -556,6 +556,11 @@ ScheduleRule ScheduleRule::MultiLevelTilingTensorCore(
     Optional<Integer> max_innermost_factor, Optional<Array<Integer>> vector_load_lens,
     Optional<Map<String, ObjectRef>> reuse_read, Optional<Map<String, ObjectRef>> reuse_write,
     bool use_software_pipeline) {
+  if (tile_binds.defined()) {
+    for (const String& tile_bind : tile_binds.value()) {
+      CHECK_NE(tile_bind, "threadIdx.x") << "Cannot bind to threadIdx.x when using tensor core.";
+    }
+  }

Review Comment:
   Yes this check covered the broken case that incorrectly using `threadIdx.x`. As a follow up, I'm thinking also adding some e2e search space generation test for the default config for each target.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [tvm] csullivan commented on a diff in pull request #13243: [MetaSchedule] Fix thread bindings of MultiLevelTilingTensorCore

Posted by GitBox <gi...@apache.org>.
csullivan commented on code in PR #13243:
URL: https://github.com/apache/tvm/pull/13243#discussion_r1009903102


##########
src/meta_schedule/schedule_rule/multi_level_tiling_tensor_core.cc:
##########
@@ -556,6 +556,11 @@ ScheduleRule ScheduleRule::MultiLevelTilingTensorCore(
     Optional<Integer> max_innermost_factor, Optional<Array<Integer>> vector_load_lens,
     Optional<Map<String, ObjectRef>> reuse_read, Optional<Map<String, ObjectRef>> reuse_write,
     bool use_software_pipeline) {
+  if (tile_binds.defined()) {
+    for (const String& tile_bind : tile_binds.value()) {
+      CHECK_NE(tile_bind, "threadIdx.x") << "Cannot bind to threadIdx.x when using tensor core.";
+    }
+  }

Review Comment:
   Does this check (along with existing tests) now cover the regression this fixes? If not adding a test to protect against the regression in the future will surely save you and others time! 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [tvm] vinx13 commented on pull request #13243: [MetaSchedule] Fix thread bindings of MultiLevelTilingTensorCore

Posted by GitBox <gi...@apache.org>.
vinx13 commented on PR #13243:
URL: https://github.com/apache/tvm/pull/13243#issuecomment-1297548018

   the unit test doesn't use default config here


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [tvm] masahi merged pull request #13243: [MetaSchedule] Fix thread bindings of MultiLevelTilingTensorCore

Posted by GitBox <gi...@apache.org>.
masahi merged PR #13243:
URL: https://github.com/apache/tvm/pull/13243


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [tvm] junrushao commented on pull request #13243: [MetaSchedule] Fix thread bindings of MultiLevelTilingTensorCore

Posted by GitBox <gi...@apache.org>.
junrushao commented on PR #13243:
URL: https://github.com/apache/tvm/pull/13243#issuecomment-1297547196

   BTW, i was curious why it's not caught by the unittests of search space generation?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [tvm] junrushao commented on pull request #13243: [MetaSchedule] Fix thread bindings of MultiLevelTilingTensorCore

Posted by GitBox <gi...@apache.org>.
junrushao commented on PR #13243:
URL: https://github.com/apache/tvm/pull/13243#issuecomment-1297585415

   we might want to add a unittest to cover the rule, but i understand it's kind of urgent. please set a reminder to add a regression test :-)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org