[jira] [Commented] (KYLIN-2974) joint group is Null lead to query error

["liyang (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/KYLIN-2974?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16223957#comment-16223957 ] 

liyang commented on KYLIN-2974:
-------------------------------

While the patch works, I don't think it hits the root cause. The validness is checked at the beginning of the method. Past this point, it should always be able to return an on-tree cuboid. There must be something else...

{code}
    public Long translateToOnTreeCuboid(long cuboidID) {
        if ((cuboidID & ~getPartialCubeFullMask()) > 0) {
            //the partial cube might not contain all required dims
            return null;
        }
{code}

> joint group is Null lead to query error
> ---------------------------------------
>
>                 Key: KYLIN-2974
>                 URL: https://issues.apache.org/jira/browse/KYLIN-2974
>             Project: Kylin
>          Issue Type: Bug
>          Components: Query Engine
>    Affects Versions: v2.1.0
>            Reporter: Yang Hao
>            Assignee: Yang Hao
>         Attachments: KYLIN-2974.patch
>
>
> When query a sql, it turns to find all possible aggregation group. But it may cause error when the joint group is empty. Relevant code is
> {code:java}
> cuboidID = cuboidID | Collections.min(agg.getJoints(), cuboidSelectComparator);
> {code}
> In our env, when we have multiple aggregation groups, it may trigger the error



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)